Add retry logic for 3DS2 challenge completion endpoint #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add retry logic to `complete3ds2Auth` so that request failures to the 3DS2 challenge completion endpoint are handled more gracefully. See `StripePaymentController#complete3ds2Auth` for details on the retry logic. Retry the request up to 3 times. Use the following backoff delay logic: - Delay 1 second before the first retry - Delay 2 seconds before the second retry - Delay 3 seconds before the third retry RUN_MOBILESDK-126
mshafrir-stripe
requested review from
aliriaz-stripe,
ccen-stripe,
michelleb-stripe and
brnunes-stripe
ccen-stripe
suggested changes
Mar 25, 2021
stripe/src/main/java/com/stripe/android/StripePaymentController.kt
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/StripePaymentController.kt
Outdated
Show resolved
Hide resolved
ccen-stripe
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add retry logic to
complete3ds2Authso that request failures tothe 3DS2 challenge completion endpoint are handled more gracefully.
See
StripePaymentController#complete3ds2Authfor details on theretry logic.
Retry the request up to 3 times. Use the following backoff delay logic:
Motivation
RUN_MOBILESDK-126
Testing