Make sure CVC, Date, and card number are always LTR regardless of the language #3524
Conversation
… language setting.
| @@ -262,6 +262,8 @@ class ExpiryDateEditText @JvmOverloads constructor( | |||
| shouldShowError = true | |||
| } | |||
| } | |||
|
|
|||
| layoutDirection = LAYOUT_DIRECTION_LTR | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I tried several different approaches to try to set this up in robolectric without any luck.
| @@ -177,6 +177,8 @@ class CardNumberEditText internal constructor( | |||
| } | |||
|
|
|||
| updateLengthFilter() | |||
|
|
|||
| this.layoutDirection = LAYOUT_DIRECTION_LTR | |||
There was a problem hiding this comment.
Should this be done in StripeEditText?
There was a problem hiding this comment.
That feels like a wide sweep, like if you used it for email address, that wouldn't work.
There was a problem hiding this comment.
That makes sense. Should we do this for PostalCodeEditText?
There was a problem hiding this comment.
Also can we add a comment in the card widgets that they are LTR only if we don't already have that?
There was a problem hiding this comment.
I did a little research, and from what I found the postal code edit text is functionality as other apps. I did make a note in the comment as well that this was explicit.
Summary
When entering credit card numbers, month, date, and cvc in countries that use rtl formatting, the text view should still be ltr.
Motivation
#3515
Testing