Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support beta header #3640

Merged
merged 7 commits into from
Apr 28, 2021
Merged

support beta header #3640

merged 7 commits into from
Apr 28, 2021

Conversation

ccen-stripe
Copy link
Contributor

Summary

Add support to add beta headers so that we can do
--header 'Stripe-Version: 2020-03-02;wechat_pay_beta=v1'

Motivation

Some API bindings are only available in beta version, we would like to support beta APIs.

This is a simplified version of #2612 without changes to PaymentConfiguration and CustomerSession, as they're not used by Wechat Pay API.
iOS has a similar approach, where a set is available override betas when initializing STPAPIClient

Wechat change incoming as a follow up PR.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments

stripe/src/main/java/com/stripe/android/ApiVersion.kt Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/ApiVersion.kt Outdated Show resolved Hide resolved
stripe/src/main/java/com/stripe/android/StripeApiBeta.kt Outdated Show resolved Hide resolved
@ccen-stripe ccen-stripe merged commit 2b1cfcf into master Apr 28, 2021
@ccen-stripe ccen-stripe deleted the addBetaHeader branch April 28, 2021 19:35
@ccen-stripe ccen-stripe mentioned this pull request Apr 28, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants