-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support beta header #3640
Merged
Merged
support beta header #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested changes
Apr 27, 2021
stripe/src/main/java/com/stripe/android/networking/StripeApiRepository.kt
Outdated
Show resolved
Hide resolved
mshafrir-stripe
requested changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments
mshafrir-stripe
previously approved these changes
Apr 28, 2021
mshafrir-stripe
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to add beta headers so that we can do
--header 'Stripe-Version: 2020-03-02;wechat_pay_beta=v1'
Motivation
Some API bindings are only available in beta version, we would like to support beta APIs.
This is a simplified version of #2612 without changes to
PaymentConfiguration
andCustomerSession
, as they're not used by Wechat Pay API.iOS has a similar approach, where a set is available override betas when initializing
STPAPIClient
Wechat change incoming as a follow up PR.
Testing
Screenshots