Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a major issue with Google Pay returning code 10, developer error, because
totalPrice
is being displayed in Eastern Arabic numerals when the locale is set to Arabic. This caused payment attempts to fail on multiple real devices.Motivation
The Google Pay API only supports Arabic numerals 0-9, not Eastern Arabic numerals ٠-٩.
Use case:
Given my locale is set to ar_AE,
When I use Stripe's
GooglePayJsonFactory.createPaymentDataRequest
,And send the JSON body to the Google Pay SDK via
PaymentsClient.loadPaymentData(PaymentDataRequest.fromJson(...)
,Then it should accept it without issues.
However, the Google Pay SDK call currently fails with error code 10, "developer error".
Example JSON that's sent to Google Pay currently and fails as per above:
Testing
Added test: PayWithGoogleUtilsTest.getPriceString_whenLocaleWithArabicNumerals_returnsExpectedValue
Without applying the bug fix, the test will fail as below: