GooglePayPaymentMethodLauncher takes transactionId and returns error code
#4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
brnunes-stripe
commented
Jul 30, 2021
...src/main/java/com/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncherContract.kt
Show resolved
Hide resolved
Comment on lines
+267
to
+269
| @Target(AnnotationTarget.PROPERTY, AnnotationTarget.VALUE_PARAMETER, AnnotationTarget.TYPE) | ||
| @IntDef(INTERNAL_ERROR, DEVELOPER_ERROR, NETWORK_ERROR) | ||
| annotation class ErrorCode |
There was a problem hiding this comment.
These are meant to be very high level to define the error message to be shown to the user.
ccen-stripe
suggested changes
Jul 30, 2021
...src/main/java/com/stripe/android/googlepaylauncher/GooglePayPaymentMethodLauncherContract.kt
Show resolved
Hide resolved
stripe-ci
assigned brnunes-stripe and unassigned mshafrir-stripe, michelleb-stripe and ccen-stripe
brnunes-stripe
assigned mshafrir-stripe, michelleb-stripe and ccen-stripe and unassigned brnunes-stripe
ccen-stripe
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GooglePayPaymentMethodLauncher.Argsto take an optionaltransactionIdargument that is passed to Google Pay.GooglePayPaymentMethodLauncher.Result.Failedto return an error code.Will follow up with similar changes to
GooglePayLauncher.Motivation
Preparing
GooglePayPaymentMethodLauncherto be used in Payment Sheet.Testing