Add support for EPS and Multibanco SourceParams creation #583
Conversation
joeydong-stripe
force-pushed
the
joeydong/moreSources
branch
7 times, most recently
from
2844ade to
042255c
Compare
| @NonNull String name, | ||
| @Nullable String email, | ||
| @Nullable String name, | ||
| @NonNull String email, |
There was a problem hiding this comment.
Switched to match what's documented at https://stripe.com/docs/sources/p24. I should investigate, was this initially a typo?
There was a problem hiding this comment.
Probably a typo but maybe need to investigate our API Docs to see if the optionality switched recently.
There was a problem hiding this comment.
@ksun-stripe does this change in nullability cause a loud error breaking change for our users? if so, that's desirable.
There was a problem hiding this comment.
It wouldn't be super loud. The nullability is used more in tooling - if it shows up, it should be more as a warning in the tools. It will be louder in Kotlin codebases.
joeydong-stripe
force-pushed
the
joeydong/moreSources
branch
2 times, most recently
from
b73ff64 to
945ee29
Compare
joeydong-stripe
changed the title
- The `dexcount-gradle-plugin`: 0.8.2 is required for the SDK to build with the latest Android Studio version - The gradle version needs to be update to date in order for ^ to build - The `google()` re-ordering is needed in order for ^ to build https://developer.android.com/studio/releases/gradle-plugin
joeydong-stripe
force-pushed
the
joeydong/moreSources
branch
from
945ee29 to
62d9941
Compare
joeydong-stripe
changed the title
joeydong-stripe
force-pushed
the
joeydong/moreSources
branch
from
62d9941 to
c398610
Compare
joeydong-stripe
changed the title
|
r? @ksun-stripe |
| @@ -1,6 +1,7 @@ | |||
| package com.stripe.android.model; | |||
|
|
|||
| import android.support.annotation.NonNull; | |||
| import android.util.Log; | |||
There was a problem hiding this comment.
Nit: I think this is probably a hold over?
FYI - Log is for Android logcat when you're running code on an Android device. You'll want system.out.print if you want to see logs appear from the tests.
Android Studio also has an optimize imports setting that will do it on the fly for you:
"Settings->Editor->Auto Import->Optimize Imports on the fly"
There was a problem hiding this comment.
Ah nice, yeah it was leftover while I was debugging a test failure
createEPSParamsandcreateMultibancoParamsmethods toSourceParamsclass