Add metadata field to Card #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** `metadata` is a field that exists on several Stripe objects. For this patch, it will only be enabled for Card-based `Source` objects. Setting `metadata` on a `Card` will ultimately populate the `metadata` field in `SourceParams` via `SourceParams#createCardParams`, which is passed along with the request to create a card-based `Source`. See https://stripe.com/docs/api/metadata This patch also does cleanup on some of the related classes (e.g. make variables final, add nullity annotations) **Motivation** Being able to set `metadata` is a user-requested feature. Most of the wiring was in place to support it, the user just needed a way to set it on a `Card`. **Testing** - Added automated tests. - In the example app, added metadata to the `Card` used in `PaymentMultilineActivity#saveCard`. Confirmed using the Dashboard's Logs feature that the metadata was included in the request and returned in the response. Fixes #472
mshafrir-stripe
force-pushed
the
metadata
branch
from
91ebec8 to
77210d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
metadatais a field that exists on several Stripe objects. For thispatch, it will only be enabled for Card-based
Sourceobjects.Setting
metadataon aCardwill ultimately populate themetadatafield in
SourceParamsviaSourceParams#createCardParams, which ispassed along with the request to create a Card-based
Source.See https://stripe.com/docs/api/metadata
This patch also does cleanup on some of the related classes (e.g.
make variables final, add nullity annotations)
Motivation
Being able to set
metadatais a user-requested feature. Most ofthe wiring was in place to support it, the user just needed a way
to set it on a
Card.Testing
Cardused inPaymentMultilineActivity#saveCard. Confirmed using theDashboard's Logs feature that the metadata was included
in the request and returned in the response.
Fixes #472