Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a11y traversal order #850

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

FrancoisBlavoet
Copy link
Contributor

Summary

the traversal order hints were weirdly reversed, I don't believe it was
on purpose.
This might explain the bug described by @russhwolf in #682 / #682 (comment)
This commit adds correct traversal instructions.
It should not cause a reoccurrence of the crash since it was caused by a node referring to itself as the next focus target and it is not the case here.

Testing

Tested on a pixel2xl thanks to the sample app with talkback enabled and using swipe gestures.

the traversal order hints were weirdly reversed, I don't believe it was
on purpose.
@mshafrir-stripe mshafrir-stripe merged commit e33de29 into stripe:master Apr 4, 2019
@FrancoisBlavoet FrancoisBlavoet deleted the traversalOrder branch April 4, 2019 18:40
@galkahana
Copy link
Contributor

@id/et_cvc_number -> @+id/et_cvc_number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants