Financial Connections: fixed/improved synchronize API all parameters.

stripe · Oct 25, 2022 · 11eb6e0 · 11eb6e0
1 parent 85eb381
commit 11eb6e0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/StripeFinancialConnections/StripeFinancialConnections/Source/API Bindings/APIVersion.swift b/StripeFinancialConnections/StripeFinancialConnections/Source/API Bindings/APIVersion.swift
@@ -15,7 +15,7 @@ struct APIVersion {
 
      - Note: Update this value when a new API version is ready for use in production.
      */
-    private static let apiVersion: Int = 1
+    static let apiVersion: Int = 1 // WARNING: this is also referenced in other places, so double check changes!
     private static let header = "financial_connections_client_api_beta=v\(apiVersion)"
 
     static func configureFinancialConnectionsAPIVersion(apiClient: STPAPIClient) {

diff --git a/...ctions/StripeFinancialConnections/Source/API Bindings/FinancialConnectionsAPIClient.swift b/...ctions/StripeFinancialConnections/Source/API Bindings/FinancialConnectionsAPIClient.swift
@@ -80,16 +80,18 @@ extension STPAPIClient: FinancialConnectionsAPIClient {
     func generateSessionManifest(clientSecret: String, returnURL: String?) -> Promise<FinancialConnectionsSynchronize> {
         let parameters: [String: Any] = [
             "client_secret": clientSecret,
-            "mobile" : [
-                "sdk_type": "ios",
-                "fullscreen": true,
-                "hide_close_button": true,
-                "sdk_version": 1,
-            ],
+            "mobile": {
+                var mobileParameters: [String:Any] = [
+                    "sdk_type": "ios",
+                    "fullscreen": true,
+                    "hide_close_button": true,
+                    "sdk_version": APIVersion.apiVersion,
+                ]
+                mobileParameters["app_return_url"] = returnURL
+                return mobileParameters
+            }(),
             "locale": Locale.current.identifier,
         ]
-        // parameters["app_return_url"] = returnURL // TODO(kgaidis): double-check these parameters
-
         return self.post(
             resource: "financial_connections/sessions/synchronize",
             parameters: parameters