Better layout for error

stripe · Feb 15, 2019 · 69d2bbb · 69d2bbb · marcus-hiles · Feb 15, 2019
1 parent 38e5a16
commit 69d2bbb
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/Stripe/STPEphemeralKeyManager.m b/Stripe/STPEphemeralKeyManager.m
@@ -86,14 +86,12 @@ - (void)_createKey {
             } else {
                 // the ephemeral key could not be decoded
                 [self.createKeyPromise fail:[NSError stp_ephemeralKeyDecodingError]];
-                NSString *protocol = @"unknown";
                 if ([self.keyProvider conformsToProtocol:@protocol(STPCustomerEphemeralKeyProvider)]) {
-                    protocol = @"STPCustomerEphemeralKeyProvider";
+                    NSAssert(NO, @"Could not parse the ephemeral key response following protocol STPCustomerEphemeralKeyProvider. Make sure your backend is sending the unmodified JSON of the ephemeral key to your app. For more info, see https://stripe.com/docs/mobile/ios/standard#prepare-your-api");
                 } else if ([self.keyProvider conformsToProtocol:@protocol(STPIssuingCardEphemeralKeyProvider)]) {
-                    protocol = @"STPIssuingCardEphemeralKeyProvider";
+                    NSAssert(NO, @"Could not parse the ephemeral key response following protocol STPCustomerEphemeralKeyProvider. Make sure your backend is sending the unmodified JSON of the ephemeral key to your app. For more info, see https://stripe.com/docs/mobile/ios/standard#prepare-your-api");
                 }
-                NSString *errorString = [NSString stringWithFormat:@"Could not parse the ephemeral key response following protocol %@. Make sure your backend is sending the unmodified JSON of the ephemeral key to your app. For more info, see https://stripe.com/docs/mobile/ios/standard#prepare-your-api", protocol];
-                NSAssert(NO, errorString);
+                NSAssert(NO, @"Could not parse the ephemeral key response. Make sure your backend is sending the unmodified JSON of the ephemeral key to your app. For more info, see https://stripe.com/docs/mobile/ios/standard#prepare-your-api");
             }
         }
         self.createKeyPromise = nil;