Handle card brand string variations (#937)

Allow parsing `AMERICAN_EXPRESS` and `DINERS_CLUB` strings as card brands.
stripe · Mar 31, 2022 · b52831e · b52831e
1 parent aa80f8e
commit b52831e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Stripe/STPPaymentMethodCard.swift b/Stripe/STPPaymentMethodCard.swift
@@ -106,15 +106,15 @@ public class STPPaymentMethodCard: NSObject, STPAPIResponseDecodable {
         let brand = string.lowercased()
         if brand == "visa" {
             return .visa
-        } else if brand == "amex" {
+        } else if brand == "amex" || brand == "american_express" {
             return .amex
         } else if brand == "mastercard" {
             return .mastercard
         } else if brand == "discover" {
             return .discover
         } else if brand == "jcb" {
             return .JCB
-        } else if brand == "diners" {
+        } else if brand == "diners" || brand == "diners_club" {
             return .dinersClub
         } else if brand == "unionpay" {
             return .unionPay

diff --git a/Tests/Tests/STPPaymentMethodCardTest.swift b/Tests/Tests/STPPaymentMethodCardTest.swift
@@ -90,6 +90,8 @@ class STPPaymentMethodCardTest: XCTestCase {
 
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "amex"), .amex)
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "AMEX"), .amex)
+        XCTAssertEqual(STPPaymentMethodCard.brand(from: "american_express"), .amex)
+        XCTAssertEqual(STPPaymentMethodCard.brand(from: "AMERICAN_EXPRESS"), .amex)
 
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "mastercard"), .mastercard)
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "MASTERCARD"), .mastercard)
@@ -102,6 +104,8 @@ class STPPaymentMethodCardTest: XCTestCase {
 
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "diners"), .dinersClub)
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "DINERS"), .dinersClub)
+        XCTAssertEqual(STPPaymentMethodCard.brand(from: "diners_club"), .dinersClub)
+        XCTAssertEqual(STPPaymentMethodCard.brand(from: "DINERS_CLUB"), .dinersClub)
 
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "unionpay"), .unionPay)
         XCTAssertEqual(STPPaymentMethodCard.brand(from: "UNIONPAY"), .unionPay)