Address element bug bash issues pt. 1 (#1363)

* Make phone optional by default

* upper case county codes

* Only suggest line 1 for auto complete

* Expand address section when auto complete line is tapped if needed

* update snapshots

* update test

* Revert "upper case county codes"

This reverts commit c17b78a6c233089a06574ee7b7029bb2a23bfc31.

* Uppercase country codes in address section element

* Revert "Expand address section when auto complete line is tapped if needed"

This reverts commit c9c47ca34046bcde98911188f9c07fdfcd3a21bc.

* Remove un-needed beginEditing call

* update test

Stripe/AddressViewController+Types.swift

@@ -73,7 +73,7 @@ import Foundation
             public var checkboxLabel: String?
 
             /// Initializes an AdditionalFields
-            public init(name: FieldConfiguration = .required, phone: FieldConfiguration = .hidden, checkboxLabel: String? = nil) {
+            public init(name: FieldConfiguration = .required, phone: FieldConfiguration = .optional, checkboxLabel: String? = nil) {
                 self.name = name
                 self.phone = phone
                 self.checkboxLabel = checkboxLabel

Stripe/AddressViewController.swift

@@ -291,10 +291,6 @@ extension AddressViewController {
         if addressSection.collectionMode == .autoCompletable,
             !AutoCompleteConstants.supportedCountries.contains(addressSection.selectedCountryCode) {
             addressSection.collectionMode = .all
-            // Slight delay to make animations smoother
-            DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-                self.addressSection.line1?.beginEditing()
-            }
         }
     }
 }

StripeUICore/StripeUICore/Source/Elements/Factories/Address/AddressSectionElement.swift

@@ -156,7 +156,7 @@ import UIKit
         additionalFields: AdditionalFields = .init(),
         theme: ElementsUITheme = .default
     ) {
-        let dropdownCountries = countries ?? addressSpecProvider.countries
+        let dropdownCountries = countries?.map{$0.uppercased()} ?? addressSpecProvider.countries
         let countryCodes = locale.sortedByTheirLocalizedNames(dropdownCountries)
         self.collectionMode = collectionMode
         self.countryCodes = countryCodes

StripeUICore/StripeUICore/Source/Elements/Factories/TextFieldElement+AddressFactory.swift

@@ -45,7 +45,7 @@ import UIKit
                 case .line2:
                     return .init(type: .default, textContentType: .streetAddressLine2, autocapitalization: .words)
                 case .autoComplete:
-                    return .init(type: .default, textContentType: .fullStreetAddress, autocapitalization: .words)
+                    return .init(type: .default, textContentType: .streetAddressLine1, autocapitalization: .words)
                 }
             }