Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable code coverage #794

Closed
TofPlay opened this issue Sep 13, 2017 · 1 comment
Closed

Disable code coverage #794

TofPlay opened this issue Sep 13, 2017 · 1 comment

Comments

@TofPlay
Copy link

TofPlay commented Sep 13, 2017

Summary

Code coverage has to be disabled for Carthage to work with Xcode 9.

Check Carthage/Carthage#2056 and Carthage/Carthage#2057.

Code to reproduce

Try to submit an application with stripe
Apple send back an email with the message:

Dear developer,

We have discovered one or more issues with your recent delivery for "<your app>". To process your delivery, the following issues must be corrected:

Invalid Bundle - Disallowed LLVM instrumentation. Do not submit apps with LLVM profiling instrumentation or coverage collection enabled. Turn off LLVM profiling or code coverage, rebuild your app and resubmit the app.

Once these issues have been corrected, you can then redeliver the corrected binary.

Regards,

The App Store team

iOS version

iOS 10 and iOS 11

Installation method

Cartfile

github "stripe/stripe-ios" "ios11"

SDK version

branche ios11

Other information

None
@bdorfman-stripe bdorfman-stripe mentioned this issue Sep 13, 2017
Merged
@bdorfman-stripe
Copy link
Contributor

This should be fixed in the latest release, 11.3.0, which just went up. Please switch to using the standard releases if you were previously using the ios11 branch. The mainline releases should now support iOS11 correctly and the other unofficial branch is no longer supported.

Please open a new issue if you have any further trouble. Thanks for your report!

mludowise-stripe added a commit that referenced this issue Mar 2, 2022
@mludowise-stripe
IDPROD-3304 (bugfix): Encode 2-digit floats as strings (#794)
5cc1825 
Stripe's API enforces that decimal numbers be
limited to 2 decimals or an API error is
returned. Sometimes (maybe 1/15 times) while
saving and ID document, the server would return
an error like:
> Invalid decimal: 0.8100000000000001

Although we were encoding `TwoDigitDecmal` to
json with the correct number of decimal places as
`0.81`, STPAPIClient uses JSONSerialization to
decode it to a Dictionary and then encode to form
data. The JSONSerialization was deserializing
this number to a Double `0.8100000000000001`
which was then being sent to the server.

This change fixes the issue by formatting the
number to a String and then encoding the String.
Since all API requests use form data, the end
result is the same, regardless of whether it's
encoded it as a string vs. a Decimal
(`.front_card_score=0.81`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TofPlay @bdorfman-stripe