-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Localization UI Tests #1051
Merged
csabol-stripe
merged 27 commits into
stripe:master
from
aa-stripe:aa-stripe/add-localization-tests
Mar 19, 2019
+1,855
−26
Merged
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ee2b9f4
Add a unit test that visits all screens in the Examples test app
aa-stripe 318f1d3
Clean up some unused code, change shipping form test data
aa-stripe eaffa83
Remove crappy Xcode UI test tokens
aa-stripe 8670e25
Change file name in comment
aa-stripe 30cc38a
STPAddCardViewController strings all covered.
csabol-stripe 5341802
Didn't need those. STPPaymentCardTextField covered
csabol-stripe b2128b3
Actually now all of STPAddCardViewController is covered
csabol-stripe 893c1c6
STPPaymentMethodsViewController covered.
csabol-stripe 8c9841a
All screens available, just need to visit them.
csabol-stripe ad2bbd6
Full coverage in tests
csabol-stripe be680d8
Autoscroll
csabol-stripe eecfa9a
Starting reverts
csabol-stripe 5882b6b
Revert "Starting reverts"
csabol-stripe b9688af
Reverts unneeded changes
csabol-stripe c444be6
Suppress autoscrolling as needed
csabol-stripe 0e02684
Add localizations to LocalizationTester
csabol-stripe a276eec
Adds screenshot script.
csabol-stripe 6b39815
Updated translations.
csabol-stripe 88c6c3f
Move the script.
csabol-stripe 342b4f9
Permissions
csabol-stripe cd246b6
Suppress keyboard.
csabol-stripe 2dd45d9
Use correct language codes
csabol-stripe a5494fd
Updates from review
csabol-stripe 1586497
Merge branch 'master' into aa-stripe/add-localization-tests
csabol-stripe b4d9005
Pulls latest translations, fixes es-AR script issue.
csabol-stripe fb061b3
Fixes string file encoding. Payment method -> payment options
csabol-stripe 2961ea0
Update reference snapshots for new translations
csabol-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-8.45 KB
(50%)
Stripe/Resources/Localizations/es-AR.lproj/Localizable.strings
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-8.55 KB
(50%)
Stripe/Resources/Localizations/fr-CA.lproj/Localizable.strings
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file modified
BIN
-8.25 KB
(50%)
Stripe/Resources/Localizations/nn-NO.lproj/Localizable.strings
Binary file not shown.
Binary file modified
BIN
-8.28 KB
(51%)
Stripe/Resources/Localizations/pt-BR.lproj/Localizable.strings
Binary file not shown.
Binary file modified
BIN
-8.4 KB
(50%)
Stripe/Resources/Localizations/pt-PT.lproj/Localizable.strings
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-6.34 KB
(57%)
Stripe/Resources/Localizations/zh-Hans.lproj/Localizable.strings
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#!/bin/bash | ||
|
||
script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
||
for i in en,US zh-HANS,CN de,DE es,ES it,IT ja,JP nl,NL fr,FR fi,FI nb,NO da,DK pt-BR,BR pt-PT,PT sv,SE es-LA,AR fr-CA,CA nn,NO; do | ||
#statements | ||
IFS=","; | ||
set -- $i; | ||
xcodebuild clean test -workspace "${script_dir}/../Stripe.xcworkspace" -scheme "LocalizationTester" -configuration "Debug" -sdk "iphonesimulator" -destination "platform=iOS Simulator,name=iPhone 6s,OS=11.4" -resultBundlePath "$HOME/Desktop/loc_qa/$1_$2" -testLanguage $1 -testRegion $2 | ||
done |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably better to keep this inside the repository, instead of putting it on the desktop. Maybe in the
build/
directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!