Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UINavigationBar translucency by default #1367

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Enable UINavigationBar translucency by default #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6486e24
Enable translucency by default on iOS 13
davidme-stripe Sep 9, 2019
80ac628
Enable translucency by default
davidme-stripe Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Stripe/PublicHeaders/STPTheme.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ NS_ASSUME_NONNULL_BEGIN

/**
A Boolean value indicating whether the navigation bar for any view controllers
presented modally by the SDK should be translucent. The default value is NO.
presented modally by the SDK should be translucent. The default value is YES.
*/
@property (nonatomic) BOOL translucentNavigationBar;

Expand Down
3 changes: 2 additions & 1 deletion Stripe/STPTheme.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ - (instancetype)init {
_errorColor = STPThemeDefaultErrorColor;
_font = STPThemeDefaultFont;
_emphasisFont = STPThemeDefaultMediumFont;
_translucentNavigationBar = NO;
_translucentNavigationBar = YES;
}
return self;
}
Expand Down Expand Up @@ -204,6 +204,7 @@ - (id)copyWithZone:(__unused NSZone *)zone {
copyTheme.errorColor = self.errorColor;
copyTheme.font = self.font;
copyTheme.emphasisFont = self.emphasisFont;
copyTheme.translucentNavigationBar = self.translucentNavigationBar;
return copyTheme;
}

Expand Down