Push provisioning take 2 #1396
Merged
Push provisioning take 2 #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-stripe
force-pushed
the
jack-push-provisioning-2
branch
from
09e08f4 to
f49f799
Compare
|
The code looks good, though I have some FUD around how App Review will treat references to PKAddPaymentPassViewController in apps that don't have the correct entitlement. We might want to send this through App Review at least once before we ship it out in an SDK. Can you fix the errors in the CI build? |
|
Ooh, good point on the app warnings. I'll try and submit something to the app store this week. Fixed the build issues in the meantime! |
|
Sounds good! I’m cool with this going in once we’ve tried that. |
davidme-stripe
approved these changes
Oct 2, 2019
ramont-stripe
added a commit
that referenced
this pull request
Sep 1, 2022
* Fix Catalyst build on Xcode 14 * Fix Swift 6 compile error * Update CHANGELOG * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a second take at the functionality in #1052.
PKAddPaymentPassViewController.STPPushProvisioningContext, a stateful class that is used to handle fetching an ephemeral key from a user's server and then using that key to call the aforementioned API.STPFakeAddPaymentPassViewController, a UI class that is API-compatible withPKAddPaymentPassViewControllerbut can be more easily used for testing and debugging.Motivation
Enable push provisioning
Testing
Added snapshot tests for the new API code.