-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FPX offline status endpoint #1422
Merged
+289
−35
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ead489b
Add FPX offline status endpoint
davidme-stripe d0ab938
Update based on feedback
davidme-stripe d38ad82
Update Stripe/STPBankSelectionViewController.m
davidme-stripe 4bb82e6
Update Stripe/STPBankSelectionViewController.m
davidme-stripe e3d3e2a
Update only visible rows
davidme-stripe c4cea21
Merge branch 'davidme/fpx-offline-status' of github.com:stripe/stripe…
davidme-stripe ba08e3d
Merge remote-tracking branch 'origin/master' into davidme/fpx-offline…
davidme-stripe 3b4bb49
Update with changes from GitHub suggestions
davidme-stripe ff55f45
Reorder Bank List
davidme-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -367,6 +367,10 @@ | |
0731329E2277ABF60019CE3F /* STPPinManagementService.m in Sources */ = {isa = PBXBuildFile; fileRef = 0731328E2277A3F60019CE3F /* STPPinManagementService.m */; }; | ||
0731329F227CFE410019CE3F /* STPIssuingCardPin.h in Headers */ = {isa = PBXBuildFile; fileRef = 073132932277A72D0019CE3F /* STPIssuingCardPin.h */; settings = {ATTRIBUTES = (Public, ); }; }; | ||
3142E72722FCC19800DDA097 /* STPFPXBankBrand.h in Headers */ = {isa = PBXBuildFile; fileRef = 31F5B33322FCAC4000A71C64 /* STPFPXBankBrand.h */; settings = {ATTRIBUTES = (Public, ); }; }; | ||
314F9CC0235E66920059E2F6 /* STPFPXBankStatusResponse.h in Headers */ = {isa = PBXBuildFile; fileRef = 314F9CBE235E66920059E2F6 /* STPFPXBankStatusResponse.h */; }; | ||
314F9CC1235E66920059E2F6 /* STPFPXBankStatusResponse.h in Headers */ = {isa = PBXBuildFile; fileRef = 314F9CBE235E66920059E2F6 /* STPFPXBankStatusResponse.h */; }; | ||
314F9CC2235E66920059E2F6 /* STPFPXBankStatusResponse.m in Sources */ = {isa = PBXBuildFile; fileRef = 314F9CBF235E66920059E2F6 /* STPFPXBankStatusResponse.m */; }; | ||
314F9CC3235E66920059E2F6 /* STPFPXBankStatusResponse.m in Sources */ = {isa = PBXBuildFile; fileRef = 314F9CBF235E66920059E2F6 /* STPFPXBankStatusResponse.m */; }; | ||
315CB85322E7BD0E00E612A3 /* libStripe3DS2.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 315CB85222E7BD0D00E612A3 /* libStripe3DS2.a */; }; | ||
315CB85522E7BD1400E612A3 /* Stripe3DS2.bundle in Resources */ = {isa = PBXBuildFile; fileRef = 315CB85422E7BD1400E612A3 /* Stripe3DS2.bundle */; }; | ||
315CB86222E7D13600E612A3 /* libStripe3DS2.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 315CB85222E7BD0D00E612A3 /* libStripe3DS2.a */; }; | ||
|
@@ -1594,6 +1598,8 @@ | |
3142E72A22FCC26600DDA097 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; }; | ||
3142E72B22FCC26600DDA097 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; }; | ||
3142E72C22FCC26600DDA097 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; }; | ||
314F9CBE235E66920059E2F6 /* STPFPXBankStatusResponse.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = STPFPXBankStatusResponse.h; sourceTree = "<group>"; }; | ||
314F9CBF235E66920059E2F6 /* STPFPXBankStatusResponse.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = STPFPXBankStatusResponse.m; sourceTree = "<group>"; }; | ||
315CB85222E7BD0D00E612A3 /* libStripe3DS2.a */ = {isa = PBXFileReference; lastKnownFileType = archive.ar; name = libStripe3DS2.a; path = InternalFrameworks/libStripe3DS2.a; sourceTree = "<group>"; }; | ||
315CB85422E7BD1400E612A3 /* Stripe3DS2.bundle */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.plug-in"; name = Stripe3DS2.bundle; path = ../InternalFrameworks/Stripe3DS2.bundle; sourceTree = "<group>"; }; | ||
315CB8A322E7D95E00E612A3 /* STDSChallengeStatusReceiver.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = STDSChallengeStatusReceiver.h; sourceTree = "<group>"; }; | ||
|
@@ -3037,6 +3043,8 @@ | |
8B429ADD1EF9EFF600F95F34 /* STPFile+Private.h */, | ||
04CDB4C41A5F30A700B854EE /* STPFormEncoder.h */, | ||
04CDB4C51A5F30A700B854EE /* STPFormEncoder.m */, | ||
314F9CBE235E66920059E2F6 /* STPFPXBankStatusResponse.h */, | ||
314F9CBF235E66920059E2F6 /* STPFPXBankStatusResponse.m */, | ||
B32B175C20F6D2C4000D6EF8 /* STPGenericStripeObject.h */, | ||
B32B175D20F6D2C4000D6EF8 /* STPGenericStripeObject.m */, | ||
36239BB022960D52004FB1A5 /* STPIntentAction+Private.h */, | ||
|
@@ -3442,6 +3450,7 @@ | |
04F94DD31D22A23F004FC826 /* NSBundle+Stripe_AppName.h in Headers */, | ||
3604007C22C18DB3004CF80B /* STPThreeDSUICustomization.h in Headers */, | ||
F1D3A25B1EB014BD0095BFA9 /* UIImage+Stripe.h in Headers */, | ||
314F9CC1235E66920059E2F6 /* STPFPXBankStatusResponse.h in Headers */, | ||
B6B41F8022348A1E0020BA7F /* STPPaymentMethodiDEALParams.h in Headers */, | ||
319A609A22E9186B00AACF66 /* STDSTextFieldCustomization.h in Headers */, | ||
3142E72722FCC19800DDA097 /* STPFPXBankBrand.h in Headers */, | ||
|
@@ -3746,6 +3755,7 @@ | |
049880FC1CED5A2300EA4FFD /* STPPaymentConfiguration.h in Headers */, | ||
C15608DD1FE08F2E0032AE66 /* UIView+Stripe_SafeAreaBounds.h in Headers */, | ||
3621DDCA22A5E4FD00281BC4 /* STPAuthenticationContext.h in Headers */, | ||
314F9CC0235E66920059E2F6 /* STPFPXBankStatusResponse.h in Headers */, | ||
F1852F931D80B6EC00367C86 /* STPStringUtils.h in Headers */, | ||
B6A46F7622FCDB81001991B2 /* STPPaymentIntentLastPaymentError.h in Headers */, | ||
049A3FAE1CC9AA9900F57DE7 /* STPAddressViewModel.h in Headers */, | ||
|
@@ -4643,6 +4653,7 @@ | |
04B31DE91D09D25F00EF1631 /* STPPaymentOptionsInternalViewController.m in Sources */, | ||
F12C8DC51D63DE9F00ADA0D7 /* STPPaymentContextAmountModel.m in Sources */, | ||
04633B011CD129CB009D4FB5 /* STPPhoneNumberValidator.m in Sources */, | ||
314F9CC3235E66920059E2F6 /* STPFPXBankStatusResponse.m in Sources */, | ||
F152322D1EA9306100D65C67 /* NSURLComponents+Stripe.m in Sources */, | ||
C159933F1D88089B0047950D /* STPShippingMethodsViewController.m in Sources */, | ||
0413CB27233FECD5006429EA /* STPPushProvisioningDetails.m in Sources */, | ||
|
@@ -4811,6 +4822,7 @@ | |
31B9609222FE128C00DC6FD9 /* STPBankSelectionViewController.m in Sources */, | ||
B63E42762231D78D007B5B95 /* STPPaymentMethodCardParams.m in Sources */, | ||
049A3FAF1CC9AA9900F57DE7 /* STPAddressViewModel.m in Sources */, | ||
314F9CC2235E66920059E2F6 /* STPFPXBankStatusResponse.m in Sources */, | ||
073132972277A72D0019CE3F /* STPIssuingCardPin.m in Sources */, | ||
04695ADC1C77F9EF00E08063 /* STPPhoneNumberValidator.m in Sources */, | ||
C1785F5E1EC60B5E00E9CFAC /* STPCardIOProxy.m in Sources */, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// | ||
// STPFPXBankStatusResponse.h | ||
// Stripe | ||
// | ||
// Created by David Estes on 10/21/19. | ||
// Copyright © 2019 Stripe, Inc. All rights reserved. | ||
// | ||
|
||
#import <Foundation/Foundation.h> | ||
|
||
#import "STPAPIResponseDecodable.h" | ||
#import "STPFPXBankBrand.h" | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
@interface STPFPXBankStatusResponse : NSObject <STPAPIResponseDecodable> | ||
|
||
- (BOOL)bankBrandIsOnline:(STPFPXBankBrand)bankBrand; | ||
|
||
@end | ||
|
||
NS_ASSUME_NONNULL_END |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooc, does this handle errors/exceptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think there's anything useful we could do with such an error. We could log them to the console, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does in the sense that we will generate an error if the response is not parseable for instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't determine if we have any standardized way to communicate these sort of errors up to developers.
retrieveFPXBankStatusWithCompletion
will return an error to the completion block if the response isn't parseable, but the BankSelectionViewController can't do anything sensible with that other than silently failing. We couldNSLog()
a warning, but we don't have any precedent for that.