Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces es-AR localization with es-419 #1549

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

csabol-stripe
Copy link
Contributor

Summary

Phrase only gave us es-AR which we used for ~Spanish - Latin America. Now we can use the actual designation of es-419

Motivation

Better localization

Testing

Built basic integration with scheme set to spanish Argentia

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Do we need to request that they're retranslated, given it's now the localization for all of latin america?

@csabol-stripe
Copy link
Contributor Author

Cool. Do we need to request that they're retranslated, given it's now the localization for all of latin america?

No they were always intended for all of Latin America

@csabol-stripe csabol-stripe removed the request for review from davidme-stripe May 18, 2020 20:19
@csabol-stripe csabol-stripe merged commit d67aceb into master May 19, 2020
@csabol-stripe csabol-stripe deleted the csabol/better_es branch May 19, 2020 17:31
kgaidis-stripe added a commit that referenced this pull request Dec 2, 2022
Financial Connections: removed iOS 13 availability flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants