Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes libpng warning for [email protected] #2752

Closed
wants to merge 1 commit into from

Conversation

jszumski
Copy link
Contributor

Summary

Fixes #2667 by converting [email protected] to 8 bit depth

Before:

$ file Stripe/StripeiOS/Resources/Images/[email protected]
Stripe/StripeiOS/Resources/Images/[email protected]: PNG image data, 51 x 51, 1-bit colormap, non-interlaced

After:

$ file Stripe/StripeiOS/Resources/Images/[email protected]
Stripe/StripeiOS/Resources/Images/[email protected]: PNG image data, 51 x 51, 8-bit/color RGBA, non-interlaced

Related: #286

Motivation

Fixes #2667

Testing

The libpng warning no longer appears when rebuilding with the updated file

Changelog

n/a

@jszumski jszumski requested review from a team as code owners July 18, 2023 18:51
@jszumski jszumski requested a review from vardges-stripe July 18, 2023 18:51
@wooj-stripe
Copy link
Collaborator

Hi @jszumski -

We generally don't accept PRs for binary files, but thank you for the submission. I've submitted a fix for this here with a thank you in our release notes here.

@wooj-stripe
Copy link
Collaborator

I am optimistically closing this PR in favor of PR 2758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PNG 8 bit warnings
2 participants