Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dead code checking #4076

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Improve dead code checking #4076

merged 4 commits into from
Sep 30, 2024

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Sep 28, 2024 •
edited
Loading

Summary

  • Removes complicated regex that was missing dead code entries
  • Formats code better

Motivation

Basic integration

Testing

#4073

Changelog

N/A

@porter-stripe porter-stripe marked this pull request as ready for review September 30, 2024 15:56
@porter-stripe porter-stripe requested review from a team as code owners September 30, 2024 15:56
@porter-stripe porter-stripe enabled auto-merge (squash) September 30, 2024 15:57
@joyceqin-stripe joyceqin-stripe self-requested a review September 30, 2024 18:40
@porter-stripe porter-stripe dismissed joyceqin-stripe’s stale review September 30, 2024 18:54

added to correct reviewer team

@porter-stripe porter-stripe merged commit 5f07c01 into master Sep 30, 2024
4 checks passed
@porter-stripe porter-stripe deleted the porter/dead-code-update branch September 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyceqin-stripe joyceqin-stripe joyceqin-stripe approved these changes

@davidme-stripe davidme-stripe Awaiting requested review from davidme-stripe

Assignees
No one assigned
Labels
basic integration deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter-stripe @joyceqin-stripe