Update promo in MPE after bank flow #4370
Draft
+249
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: StripeAttestBackend.swift:24 warning: Parameter 'appId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'deviceId' is unused
StripeAttestBackend.swift:24 warning: Parameter 'keyId' is unused
StripeAttestBackend.swift:20 warning: Parameter 'attestation' is unused
StripeAttestBackend.swift:14 warning: Property 'apiClient' is assigned, but never used
SavedPaymentMethodRowButton.swift:9 warning: Imported module 'StripeCore' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
2 times, most recently
from
5ad3d19 to
b83e20a
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
3 times, most recently
from
2ed15ab to
242910b
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
from
b83e20a to
e564e9e
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-fetch-available-incentives
branch
5 times, most recently
from
cabfd94 to
98c8d0d
Compare
Base automatically changed from
tillh/ibp-incentives-fetch-available-incentives
to
master
January 13, 2025 16:18
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
2 times, most recently
from
1e979a0 to
d9df82d
Compare
tillh-stripe
commented
Jan 13, 2025
...Sheet/Source/PaymentSheet/Vertical Main Screen/VerticalPaymentMethodListViewController.swift
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
3 times, most recently
from
2bba9f1 to
8d2951b
Compare
mats-stripe
previously approved these changes
Jan 14, 2025
| @@ -164,6 +169,11 @@ final class InstantDebitsPaymentMethodElement: ContainerElement { | |||
|
|
|||
| return nameValid && emailValid && phoneValid && addressValid | |||
| } | |||
|
|
|||
| var displayableIncentive: PaymentMethodIncentive? { | |||
| let canShowIncentive = linkedBank?.incentiveEligible ?? true | |||
There was a problem hiding this comment.
Any reason we default to true here? I'd expect the opposite
There was a problem hiding this comment.
If we don’t have a linked bank yet (and therefore no info if the session is eligible), we assume that the link_consumer_incentive as coming from the backend is valid. Otherwise, we would never show the incentive before the user completes the flow 🙈
...StripePaymentSheet/Source/PaymentSheet/USBankAccount/InstantDebitsPaymentMethodElement.swift
Outdated
Show resolved
Hide resolved
...Sheet/Source/PaymentSheet/Vertical Main Screen/VerticalPaymentMethodListViewController.swift
Outdated
Show resolved
Hide resolved
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
2 times, most recently
from
19ff93c to
8ae81af
Compare
tillh-stripe
changed the base branch from
master
to
tillh/ibp-incentives-header-badge-again
tillh-stripe
force-pushed
the
tillh/ibp-incentives-header-badge-again
branch
from
7700e8a to
4314eaf
Compare
- Rename `updateLinkedBank` to `renderLinkedBank` for greater clarity - Add explanatory comment to `canShowIncentive` - Make `refreshContent` a method instead of a property
tillh-stripe
force-pushed
the
tillh/ibp-incentives-update-mpe-after-flow
branch
from
8ae81af to
10b949a
Compare
Base automatically changed from
tillh/ibp-incentives-header-badge-again
to
master
January 17, 2025 20:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds code to refresh the MPE’s promo information after the bank auth flow completes. If no incentive is available, the promo badge in the carousel and bank form should be updated accordingly.
Motivation
CONSUMERBANK-571
Testing
Changelog