Header text says manage cards instead of manage payment methods when only cards available #4449
Conversation
|
Manage cards If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link. |
I forgot this wasn't specifically for the default sync project, my bad |
| @@ -70,12 +70,15 @@ class VerticalSavedPaymentMethodsViewController: UIViewController { | |||
| } | |||
|
|
|||
| private var headerText: String { | |||
| let nonCardPaymentMethods = paymentMethods.filter({ $0.type != .card }) | |||
| let onlyCards = nonCardPaymentMethods.isEmpty | |||
There was a problem hiding this comment.
I typically like to name booleans in a way that answers a yes or no question.. e.g.(is..., has..., etc) -- e.g. hasOnlyCards
There was a problem hiding this comment.
That makes sense, renamed it to hasOnlyCards
| let nonCardPaymentMethods = paymentMethods.filter({ $0.type != .card }) | ||
| let hasOnlyCards = nonCardPaymentMethods.isEmpty |
There was a problem hiding this comment.
Nit: Could be let hasOnlyCards = paymentMethods.filter({ $0.type != .card }).isEmpty
Summary
In vertical mode, when the only saved payment methods are cards, in edit mode, it now says "Manage cards" instead of "Manage payment methods" since in non-edit mode it says "Select card" instead of "Select payment method"
Motivation
MOBILESDK-2890
Testing
Changelog