Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dismiss to ApplePayContext #4470

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

yuki-stripe
Copy link
Collaborator

Summary

See https://stripe.slack.com/archives/C0353FPANQ0/p1736808910348399

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2987
#3558

Testing

Added unit test, does not actually test we call cancel under the hood though.

Manually tested calling the cancel API after I receive the payment method:

Simulator.Screen.Recording.-.snapshot.tester.iPhone.12.mini.16.4.-.2025-01-13.at.15.59.20.mp4

Changelog

See CHANGELOG

Copy link

github-actions bot commented Jan 15, 2025

⚠️ Public API changes detected:

StripeApplePay

- public func dismiss(completion: StripeApplePay.STPVoidBlock? = nil)

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@yuki-stripe yuki-stripe merged commit 41f58f3 into master Jan 15, 2025
7 of 8 checks passed
@yuki-stripe yuki-stripe deleted the yuki/add-applepaycontext-cancel branch January 15, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants