-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show blocked brands in CBC dropdown, but block selection #4489
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e68e183
Show blocked brands in CBC dropdown, but block selection
porter-stripe 4a385dd
Remove old test file
porter-stripe 91d80d8
Add a test
porter-stripe 4ebc12d
Add localized string
porter-stripe becb82b
Change text on update screen when the user can't update their brand
porter-stripe fdca996
Update CBC auto selection logic
porter-stripe 4c073f1
Fix auto selection logic
porter-stripe f4288c3
Merge branch 'master' into porter/cbf-cbc-ga
porter-stripe 3b2a3f4
Add a snapshot test
porter-stripe 8bb7467
Merge branch 'porter/cbf-cbc-ga' of github.com:stripe/stripe-ios into…
porter-stripe 6a20433
Update test_UpdatePaymentMethodViewControllerLightMode_blockedBrands@…
porter-stripe 9a4fe2f
Only auto select if we have blocked brands
porter-stripe 69bb440
isAllowed replaced with isDisallowed
porter-stripe 2225c59
Refactor "canUpdateCardBrand"
porter-stripe 48539aa
Assert size of list in test
porter-stripe c2e06cd
Assert item count in DropdownFieldElement
porter-stripe 2866fc0
PR feedback/refactor
porter-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
...PaymentSheet/StripePaymentSheet/Source/PaymentSheet/STPCardValidator+BrandFiltering.swift
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 0 additions & 57 deletions
57
...ymentSheet/StripePaymentSheetTests/PaymentSheet/STPCardValidator+BrandFilteringTest.swift
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having a tough time following this logic, so i tried to refactor it a bit.... Let me know what you think about breaking up this logic in the following way:
Then we take the logic out of those ifstatements into two separate functions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I like this better!