Fixes and testing for merchant-initiated repair flows #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 builds increased size, 6 builds had no size change
StripeSize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| 📝 StripeFinancialConnections.NativeFlowController.pushPane(paramete... | ⬆️ 3.1 kB |
| 🗑 StripeFinancialConnections.NativeFlowController.pushPane(paramete... | ⬇️ -1.6 kB |
| StripeFinancialConnections.PartnerAuthViewController.createdAuthS... | ⬆️ 1.4 kB |
| Other | ⬆️ 1.1 kB |
View Treemap
StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 3.9 kB (0.07%)
Total download size change: ⬆️ 1.6 kB (0.1%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 📝 StripeFinancialConnections.NativeFlowController.pushPane(paramete... | ⬆️ 3.1 kB |
| 🗑 StripeFinancialConnections.NativeFlowController.pushPane(paramete... | ⬇️ -1.6 kB |
| StripeFinancialConnections.PartnerAuthViewController.createdAuthS... | ⬆️ 1.4 kB |
| Other | ⬆️ 1.1 kB |
View Treemap
🛸 Powered by Emerge Tools
tillh-stripe
force-pushed
the
tillh/fc-repair-flow
branch
3 times, most recently
from
2e5dd8c to
94eb9fb
Compare
tillh-stripe
force-pushed
the
tillh/fc-repair-flow
branch
from
94eb9fb to
841b0fa
Compare
mats-stripe
previously approved these changes
Feb 3, 2025
| setNavigationControllerViewControllers([paneViewController], animated: animated) | ||
| } else if removeCurrent, let paneViewController { | ||
| let viewControllers = Array(navigationController.viewControllers.dropLast()) | ||
| setNavigationControllerViewControllers(viewControllers + [paneViewController], animated: animated) |
There was a problem hiding this comment.
In this scenario, is there a back button on the current pane? If so, pressing it would skip the immediately previous pane the user saw and go back two panes. Would this UX feel disjointed at all?
There was a problem hiding this comment.
Yep, that’s what will happen and is in line with the behavior on Web.
...le/FinancialConnections Example/FinancialConnections Example/Playground/PlaygroundView.swift
Outdated
Show resolved
Hide resolved
...le/FinancialConnections Example/FinancialConnections Example/Playground/PlaygroundView.swift
Outdated
Show resolved
Hide resolved
...ialConnections Example/FinancialConnections Example/Playground/PlaygroundConfiguration.swift
Show resolved
Hide resolved
Add placeholder hints in text fields
mats-stripe
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes fixes for merchant-initiated repair flows in Financial Connections. We also now allow testing these flows from the playground by entering a customer and authorization ID.
Motivation
Testing
Changelog