Create dynamic bank icon placeholder image #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we were using a static image as the placeholder when waiting to download an institution icon from the network - this isn't dark mode friendly. Instead of adding a new static image for dark mode, this renders a dynamic image appropriate for the current appearance settings.
This also updates to the latest
bankicon from Sail.Note
Shadows in dark mode look weird - I will fix this across the board in a separate PR.
Motivation
Polish dark mode ✨
Testing
Manual testing - see screenshots above!
Changelog
N/a