Delete unused Basic Integration analytics #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfriedman-stripe
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
LGTM, but did Periphery not catch this? cc @porter-stripe @joyceqin-stripe
|
@sfriedman-stripe It looks like this is a limitation of Periphery. These events are case's on part of an enum which have an associated value (String). According to Periphery's docs these cannot be reliably analyzed to determine if they are used or not. You can see an example of why not in their docs. https://github.com/peripheryapp/periphery?tab=readme-ov-file#enumerations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3880
Testing
n/a
Changelog
not user facing