-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Nulls Deeply #747
Remove Nulls Deeply #747
Conversation
hmm. my guess is there probably aren't many users at the intersection of
seems like a worthwhile improvement to me, and worth the small risk of a subtle break as long as we call it out in MIGRATING |
I guess the trickiest thing you can end up doing is something like: if (card.allResponseFields[@"metadata"][@"username"] != nil) {
// Do something without actually checking the value of metadata.username
} |
7534652
to
3cccd8d
Compare
We're going to add a few more helpers to this category but not so many that a separate category namespace is neccessary
Nulls are particularly difficult to work with in any situation so filter them out everywhere
3cccd8d
to
a6bbd6e
Compare
r? @bg-stripe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Oops forgot too add an entry to the CHANGELOG |
…747) * Pass new card cvc to Link intent completion * Include cvc updates
Summary
Improve the NSDictionary / NSArray remove nulls helpers to scan deeply instead of only at the first level.
Motivation
Nulls are particularly difficult to work with in any situation so just filter them out everywhere.
Testing
Updated unit tests.