-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v11.3.0 #796
Release v11.3.0 #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs more changelog detail, I left comments inline.
Also MIGRATING.md still says version X.Y.Z in it
Btw, for future proposal PRs I would suggest doing the documentation regen in a separate commit to make the diff easier to look at.
CHANGELOG.md
Outdated
@@ -1,4 +1,5 @@ | |||
## X.Y.Z 2017-XX-YY | |||
## 11.3.0 2017-09-13 | |||
* Improved support and compatibility with iOS 11 | |||
* Changes and fixes methods on `STPCard`, `STPCardParams`, `STPBankAccount`, and `STPBankAccountParams` to bring card objects more in line with the rest of the API. See MIGRATING for further details. | |||
* Adds nullability annotations to `STPPaymentMethod` protocol | |||
* Improves the `[STPAPIResponseDecodable allResponseFields]` by removing all instances of `[NSNull null]` including ones that are nested. See MIGRATING.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some other changes that need to go in here, such as:
support for p24 in our bindings
support for direct app-to-app Alipay redirects.
fixing this crash #786
I usually browse through the "x commits to master since this release" link for the latest release when I'm doing the new proposal btw, to make sure all important user facing PRs are covered by the changelog.
Also not sure if we want to expand on the iOS 11 compatibility at all? Or call out the back button changes?
* Fix logged out email check * Move `allowSync` default param value to protocol
Stripe.podspec
(make sure there aren't any new directories added, and if so, add them to the "files" section./ci_scripts/build_documentation.sh
pod lib lint
succeeds without warnings or errors./ci_scripts/export_builds.sh
succeeds without warnings or errorsPS: Use correct Xcode version
r? @bdorfman-stripe