Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v11.3.0 #796

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Release v11.3.0 #796

merged 2 commits into from
Sep 14, 2017

Conversation

joeydong-stripe
Copy link
Contributor

@joeydong-stripe joeydong-stripe commented Sep 13, 2017

  • Update README (if necessary)
  • Update CHANGELOG with any new features or breaking changes
  • Update MIGRATING (if necessary)
  • Update STPSDKVersion in STPAPIClient.h
  • Update version in Info.plist (make sure to not change the "InfoDictionary" field)
  • Update VERSION
  • Update Stripe.podspec (make sure there aren't any new directories added, and if so, add them to the "files" section
  • Update documentation: ./ci_scripts/build_documentation.sh
  • Make sure pod lib lint succeeds without warnings or errors
  • Make sure ./ci_scripts/export_builds.sh succeeds without warnings or errors

PS: Use correct Xcode version

r? @bdorfman-stripe

Copy link
Contributor

@bdorfman-stripe bdorfman-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs more changelog detail, I left comments inline.

Also MIGRATING.md still says version X.Y.Z in it

Btw, for future proposal PRs I would suggest doing the documentation regen in a separate commit to make the diff easier to look at.

CHANGELOG.md Outdated
@@ -1,4 +1,5 @@
## X.Y.Z 2017-XX-YY
## 11.3.0 2017-09-13
* Improved support and compatibility with iOS 11
* Changes and fixes methods on `STPCard`, `STPCardParams`, `STPBankAccount`, and `STPBankAccountParams` to bring card objects more in line with the rest of the API. See MIGRATING for further details.
* Adds nullability annotations to `STPPaymentMethod` protocol
* Improves the `[STPAPIResponseDecodable allResponseFields]` by removing all instances of `[NSNull null]` including ones that are nested. See MIGRATING.md.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some other changes that need to go in here, such as:
support for p24 in our bindings
support for direct app-to-app Alipay redirects.
fixing this crash #786

I usually browse through the "x commits to master since this release" link for the latest release when I'm doing the new proposal btw, to make sure all important user facing PRs are covered by the changelog.

Also not sure if we want to expand on the iOS 11 compatibility at all? Or call out the back button changes?

@joeydong-stripe
Copy link
Contributor Author

r? @bdorfman-stripe

@bdorfman-stripe bdorfman-stripe merged commit 00d0547 into master Sep 14, 2017
@bdorfman-stripe bdorfman-stripe deleted the joey-release-v11.3.0 branch September 14, 2017 17:05
mludowise-stripe pushed a commit that referenced this pull request Mar 2, 2022
* Fix logged out email check

* Move `allowSync` default param value to protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants