Release v11.5.0 #835
Release v11.5.0 #835
Conversation
* Update README: * We support building with either Xcode 8 or 9 * Use example backend app at the tip of master, instead of linking to a specific tag. * Update CHANGELOG * Update `STPSDKVersion` * Update versions in `Info.plist` * Update `VERSION` * Update `Stripe.podspec`
README.md
Outdated
| @@ -49,7 +50,7 @@ To try out any of these examples, clone this repository, open `Stripe.xcworkspac | |||
| 1. Execute `./setup.sh` from the root of the repository to build the necessary dependencies. | |||
| 2. If you haven't already, sign up for a [Stripe account](https://dashboard.stripe.com/register) (it takes seconds). Then go to https://dashboard.stripe.com/account/apikeys. | |||
| 3. Replace the `stripePublishableKey` constant in CheckoutViewController.swift (for the Standard Integration app) or Constants.m (for the Custom Integration app) with your Test Publishable Key. | |||
| 4. Head to https://github.com/stripe/example-ios-backend/tree/v11.0.0 and click "Deploy to Heroku" (you may have to sign up for a Heroku account as part of this process). Provide your Stripe test secret key for the STRIPE_TEST_SECRET_KEY field under 'Env'. Click "Deploy for Free". | |||
| 4. Head to https://github.com/stripe/example-ios-backend and click "Deploy to Heroku" (you may have to sign up for a Heroku account as part of this process). Provide your Stripe test secret key for the STRIPE_TEST_SECRET_KEY field under 'Env'. Click "Deploy for Free". | |||
There was a problem hiding this comment.
Why did you remove the versioned link from the backend url?
There was a problem hiding this comment.
@ksun-stripe made updates to the example-ios-backend, and that tag isn't current any more. We could also re-tag it and update the link to the new tag, but I wasn't sure why we wouldn't just want to link people to master
There was a problem hiding this comment.
Ah we specifically wanted to start making tagged releases for the backend and having the tagged releases here match up to the version of the backend that supports this version of the sdk. Otherwise you can get confusing version mismatches (eg latest master on backend might not match the latest tagged release of the sdk. Or if you are on an old version you can't easily figure out what version of the backend you need).
If Kathy has made new changes to the backend that we want people to be using with 11.5.0 we should create a new tagged version for the backend and link that here instead.
The latest changes were for Android support, and the iOS app continues to work fine with v11.0.0 of the backend.
|
LGTM |
* Remove separator * Display the menu on top of the active digit view
Update MIGRATING (if necessary)Stripe.podspec(make sure there aren't any new directories added, and if so, add them to the "files" section./ci_scripts/build_documentation.shpod lib lintsucceeds without warnings or errors./ci_scripts/export_builds.shsucceeds without warnings or errors