-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change minimum requirements to Xcode9 / iOS 9 #851
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
557a8bf
Bump minimum versions to 9
bdorfman-stripe 41522f5
Remove all references to AddressBook framework
bdorfman-stripe 707608a
Remove iOS 9 availability guard
bdorfman-stripe f4bbc22
Change test platform version
bdorfman-stripe b41f649
Fix availability for geocoder
bdorfman-stripe aa96b4e
Re-enable availability warnings
bdorfman-stripe f301970
Renable fauxpas for static target and disable APIAvailability
bdorfman-stripe 2da9894
Fixup availability checks
bdorfman-stripe 2e06036
Change travis/tests to run on Xcode9/iOS11.2
bdorfman-stripe 8a41e94
Use auto scroll content insetting
bdorfman-stripe 91add43
Extract working ViewController snapshot setup code into a helper
bdorfman-stripe ae5899b
Update view controller snapshot tests
bdorfman-stripe 39d344f
Update migrating
bdorfman-stripe 26641ba
Merge branch 'master' into bdorfman-xcode9-ios9
bdorfman-stripe 9cd8541
Update to Xcode 9.2 recommended project settings
bdorfman-stripe 3ef1ebb
Fix FauxPas header
bdorfman-stripe 0788c85
Update changelog to mention AddressBook
bdorfman-stripe ba65f9e
Fix fauxpas warning
bdorfman-stripe 8bcc8cb
Reverse product bundle identifier changes.
bdorfman-stripe c52130c
Fix typo in MIGRATING
bdorfman-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // FBSnapshotTestCase+STPViewControllerLoading.h | ||
| // StripeiOS Tests | ||
| // | ||
| // Created by Brian Dorfman on 12/11/17. | ||
| // Copyright © 2017 Stripe, Inc. All rights reserved. | ||
| // | ||
|
|
||
| #import <FBSnapshotTestCase/FBSnapshotTestCase.h> | ||
|
|
||
| @interface FBSnapshotTestCase (STPViewControllerLoading) | ||
| - (UIView *)stp_preparedAndSizedViewForSnapshotTestFromViewController:(UIViewController *)viewController; | ||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // | ||
| // FBSnapshotTestCase+STPViewControllerLoading.m | ||
| // StripeiOS Tests | ||
| // | ||
| // Created by Brian Dorfman on 12/11/17. | ||
| // Copyright © 2017 Stripe, Inc. All rights reserved. | ||
| // | ||
|
|
||
| #import "FBSnapshotTestCase+STPViewControllerLoading.h" | ||
| #import "STPCoreScrollViewController+Private.h" | ||
|
|
||
| @implementation FBSnapshotTestCase (STPViewControllerLoading) | ||
| - (UIView *)stp_preparedAndSizedViewForSnapshotTestFromViewController:(UIViewController *)viewController { | ||
| UINavigationController *navController = [[UINavigationController alloc] initWithRootViewController:viewController]; | ||
| UIWindow *testWindow = [[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 320, 480)]; | ||
| testWindow.rootViewController = navController; | ||
| testWindow.hidden = NO; | ||
|
|
||
| // Test that loaded properly + loads them on first call | ||
| XCTAssertNotNil(navController.view); | ||
| XCTAssertNotNil(viewController.view); | ||
|
|
||
| if ([viewController isKindOfClass:[STPCoreScrollViewController class]]) { | ||
| UIScrollView *scrollView = ((STPCoreScrollViewController *)viewController).scrollView; | ||
| [navController.view layoutIfNeeded]; | ||
|
|
||
| CGFloat topOffset = [scrollView convertPoint:scrollView.frame.origin toCoordinateSpace:navController.view].y; | ||
| navController.view.frame = CGRectMake(0, 0, 320, topOffset + scrollView.contentSize.height + scrollView.contentInset.top + scrollView.contentInset.bottom); | ||
| } | ||
|
|
||
| return navController.view; | ||
| } | ||
| @end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍