Fix STPAddressViewModel.isValid to use country when requiredBillingFields = .Zip
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why does the last assert of `testIsValid_Zip` fail? An `STPAddressViewModel` with required billing fields == `Zip` pass a `nil` country to determine if it `isValid`, and therefore will *always* incorrectly report that countries without postal codes are invalid.
… `STPAddressViewModel` When there's no country table cell/text field, the country information is stored in `addressFieldTableViewCountryCode`. This fixes #840, because the address used to check `isValid` is created through this method. I think this is a desirable change overall. When `setAddress:` is called, it extracts the `STPAddress.country` value, and stores it into `addressFieldTableViewCountryCode`. It makes a lot of sense to me to reverse that when reading the `STPAddress` back out of the object.
…rent country I observed this bug while testing. The toolbar with 'Next' (above the number pad) was visible for countries without postal codes. When the paymentCell was completely filled, the 'Next' button enabled, but did nothing when tapped. Instead of special-casing on the `configuration.requiredBillingAddressFields`, just use the logic already built into `STPAddressViewModel` to know whether there'll be a field to change to.
danj-stripe
added a commit
that referenced
this pull request
Dec 15, 2017
danj-stripe
added a commit
that referenced
this pull request
Dec 18, 2017
mludowise-stripe
pushed a commit
that referenced
this pull request
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had a bug, where
STPAddressViewModelobjects that only require the Postal Code didnot use the country when calculating
isValid, but did use the country when decidingwhether or not to show the postal code field.
This resulted in a stuck user: they couldn't add a credit card, because the
STPAddCardViewControllerwas waiting for them to enter a postal code, but didn't allowthem to.
Additionally, in this case we were also incorrectly showing the
inputAccessoryToolbarwith a 'Next' button that did nothing.
Motivation
Fixes #840
Testing
Augmented
STPAddressViewModelTestto capture this case, and protect against regressions.Further, manual testing in the Standard Integration app, both US & Macau (req'd postal &
non-req'd postal code), and all three values of
STPBillingAddressFields(none, zip, full)