Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release iOS SDK v12.1.3 #930

Closed
wants to merge 3 commits into from
Closed

Release iOS SDK v12.1.3 #930

wants to merge 3 commits into from

Conversation

danj-stripe
Copy link
Contributor

@danj-stripe danj-stripe commented Apr 24, 2018

  • Update README
  • Update CHANGELOG with any new features or breaking changes
  • Update MIGRATING (if necessary)
  • Update STPSDKVersion in STPAPIClient.h
  • Update version in Info.plist (make sure to not change the "InfoDictionary" field)
  • Update VERSION
  • Update Stripe.podspec (make sure there aren't any new directories added, and if so, add them to the "files" section
  • Update documentation: ./ci_scripts/build_documentation.sh
  • Make sure pod lib lint succeeds without warnings or errors.
  • Make sure ./ci_scripts/export_builds.sh succeeds without warnings or errors

…v0.9.2

v0.9.2 seems to add some anchor tags for Protocols & Categories, otherwise I just
see the new content from #928 and then new version numbers and dates.
@danj-stripe
Copy link
Contributor Author

./ci_scripts/export_builds.sh fails on my machine with Xcode 9.2. Both 9.1 and 9.3 work.

While building module 'PassKit' imported from /Users/danj/stripe/stripe-ios/Stripe/PublicHeaders/STPBlocks.h:10:
In file included from <module-includes>:1:
In file included from /Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PassKit.h:38:
/Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PKPaymentAuthorizationViewController.h:148:99: error: expected a type
+ (BOOL)canMakePaymentsUsingNetworks:(NSArray<PKPaymentNetwork> *)supportedNetworks capabilities:(PKMerchantCapability)capabilties API_AVAILABLE(ios(9.0));
                                                                                                  ^
/Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PKPaymentAuthorizationViewController.h:156:50: error: expected a type
- (nullable instancetype)initWithPaymentRequest:(PKPaymentRequest *)request NS_DESIGNATED_INITIALIZER;
                                                 ^
While building module 'PassKit' imported from /Users/danj/stripe/stripe-ios/Stripe/PublicHeaders/STPBlocks.h:10:
In file included from <module-includes>:1:
In file included from /Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PassKit.h:41:
/Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PKPaymentAuthorizationController.h:125:99: error: expected a type
+ (BOOL)canMakePaymentsUsingNetworks:(NSArray<PKPaymentNetwork> *)supportedNetworks capabilities:(PKMerchantCapability)capabilties;
                                                                                                  ^
/Applications/Xcode 9.2.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/PassKit.framework/Headers/PKPaymentAuthorizationController.h:131:41: error: expected a type
- (instancetype)initWithPaymentRequest:(PKPaymentRequest *)request NS_DESIGNATED_INITIALIZER;
                                        ^
4 errors generated.
In file included from /Users/danj/stripe/stripe-ios/Stripe/STPSourcePoller.m:9:
In file included from /Users/danj/stripe/stripe-ios/Stripe/STPSourcePoller.h:10:
/Users/danj/stripe/stripe-ios/Stripe/PublicHeaders/STPBlocks.h:10:9: fatal error: could not build module 'PassKit'
#import <PassKit/PassKit.h>
 ~~~~~~~^
5 errors generated.

@danj-stripe
Copy link
Contributor Author

Must be something wrong with that copy of Xcode. A fresh download works, and it works fine on joeydong-stripe's machine.

@danj-stripe danj-stripe deleted the danj/release/v12.1.3 branch April 26, 2018 18:02
@danj-stripe
Copy link
Contributor Author

Closed in favor of #933, due to #931 (a breaking change)

jaimepark-stripe pushed a commit that referenced this pull request Apr 11, 2022
* Read tint color off appearance

* Update primaryButtonColor behavior to interact with appearance

* Assert sizeScaleFactor > 0.0

* Hide shadow on StackViewWithSep

* Make afterpay logo dynamic to background color

* Set font on edit button

* Remove shape, make shadow optional

* Add doc comments

* Make colors plural

* Remove STP protection

* Make dividers take on borderWidth

* Remove hardcoded font size in API

* Couple of naming updates from API review

* Make loading icon dynamic black/white

* Fix harsh shadow in saved PM list (shadow handled by shadowRoundedRectangle)

* Fix issue after merge

* Revert "Remove STP protection"

This reverts commit abdfdefe0e402641b912772275cda8268cf4e85b.

* update snapshots after merge

* update snapshots

* Use accessibility XL instead of size XL

* Doc comment suggestion 1

Co-authored-by: Yuki <[email protected]>

* Use CGFloat

Co-authored-by: Yuki <[email protected]>

* Doc comment suggestion

Co-authored-by: Yuki <[email protected]>

* Doc comment suggestion

Co-authored-by: Yuki <[email protected]>

* DefaultColors -> DefaultColor

* Remove comment about appearance.colors.primary

* Use shadow radius

* Add strong typings

* alpha -> opacity

* Make primaryButtonColor optional

* font.regular -> font.base

* Doc comment update

Co-authored-by: Yuki <[email protected]>

* Add "regular" to font

* update snapshots

* Update testPaymentSheetStandardCardSnapshot_darkModeAndReturnError_@3x.png

* Update testPaymentSheetStandardCardSnapshot_darkModeAndReturnError_@3x.png

Co-authored-by: Yuki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant