Add string as valid deliveryEstimate value for ECE (#520)

* Add string as valid deliveryEstimate value for ECE * linting/style improvements * Add deliveryEstimate test that accepts string
stripe · Oct 25, 2023 · db429aa · db429aa
1 parent 2274d67
commit db429aa
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/tests/types/src/valid.ts b/tests/types/src/valid.ts
@@ -981,6 +981,12 @@ expressCheckoutElement.on(
             },
           },
         },
+        {
+          id: 'fast-shipping',
+          amount: 300,
+          displayName: 'Pizza time, soon',
+          deliveryEstimate: 'A couple of weeks',
+        },
         {
           id: 'free-shipping',
           amount: 0,

diff --git a/types/stripe-js/elements/express-checkout.d.ts b/types/stripe-js/elements/express-checkout.d.ts
@@ -230,10 +230,12 @@ export type ShippingRate = {
   id: string;
   amount: number;
   displayName: string;
-  deliveryEstimate?: {
-    maximum?: DeliveryEstimate;
-    minimum?: DeliveryEstimate;
-  };
+  deliveryEstimate?:
+    | string
+    | {
+        maximum?: DeliveryEstimate;
+        minimum?: DeliveryEstimate;
+      };
 };
 
 export type LayoutOption = {