Add verify microdeposits type to SetupIntent next action object #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdaily-stripe
changed the title
bdaily-stripe
force-pushed
the
bdaily-fix-gaps-in-si-next-actions
branch
from
27cdd86 to
31722f3
Compare
bdaily-stripe
commented
Oct 1, 2024
bdaily-stripe
force-pushed
the
bdaily-fix-gaps-in-si-next-actions
branch
from
31722f3 to
7b92acd
Compare
bdaily-stripe
force-pushed
the
bdaily-fix-gaps-in-si-next-actions
branch
from
7b92acd to
85f6186
Compare
bdaily-stripe
changed the title
awalker-stripe
approved these changes
Oct 4, 2024
| /** | ||
| * Type of the next action to perform, one of `redirect_to_url` or `use_stripe_sdk`. | ||
| * Type of the next action to perform, one of `redirect_to_url`, `use_stripe_sdk`, or `verify_with_microdeposits`. | ||
| */ | ||
| type: string; |
There was a problem hiding this comment.
At this point it's likely not worth fixing, especially since it would be a breaking change, but I wonder why we used string instead of hardcoding type: 'redirect_to_url' | 'use_stripe_sdk' | 'verify_with_microdeposits'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Add a missing hash to SetupIntent.NextAction for microdeposits. Also updates the documentation for
type.Testing & documentation
Added type tests
Fixes #630