Revert "Add raw_request (#2185)" (#2188)

This reverts commit 6d3cef2.
stripe · Sep 25, 2024 · 1b5ff05 · 1b5ff05
1 parent 6d3cef2
commit 1b5ff05
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 387 deletions.
diff --git a/README.md b/README.md
@@ -517,40 +517,6 @@ const stripe = new Stripe('sk_test_...', {
 });
 ```
 
-### Custom requests
-
-If you would like to send a request to an undocumented API (for example you are in a private beta), or if you prefer to bypass the method definitions in the library and specify your request details directly, you can use the `rawRequest` method on the StripeClient object.
-
-```javascript
-const client = new Stripe('sk_test_...');
-
-client.rawRequest(
-    'POST',
-    '/v1/beta_endpoint',
-    { param: 123 },
-    { apiVersion: '2022-11-15; feature_beta=v3' }
-  )
-  .then((response) => /* handle response */ )
-  .catch((error) => console.error(error));
-```
-
-Or using ES modules and `async`/`await`:
-
-```javascript
-import Stripe from 'stripe';
-const stripe = new Stripe('sk_test_...');
-
-const response = await stripe.rawRequest(
-  'POST',
-  '/v1/beta_endpoint',
-  { param: 123 },
-  { apiVersion: '2022-11-15; feature_beta=v3' }
-);
-
-// handle response
-```
-
-
 ## Support
 
 New features and bug fixes are released on the latest major version of the `stripe` package. If you are on an older major version, we recommend that you upgrade to the latest in order to use the new features and bug fixes including those for security vulnerabilities. Older major versions of the package will continue to be available for use, but will not be receiving any updates.

diff --git a/src/RequestSender.ts b/src/RequestSender.ts
@@ -11,8 +11,6 @@ import {
   normalizeHeaders,
   removeNullish,
   stringifyRequestData,
-  getDataFromArgs,
-  getOptionsFromArgs,
 } from './utils.js';
 import {HttpClient, HttpClientResponseInterface} from './net/HttpClient.js';
 import {
@@ -26,8 +24,6 @@ import {
   RequestData,
   RequestOptions,
   RequestDataProcessor,
-  RequestOpts,
-  RequestArgs,
 } from './Types.js';
 
 export type HttpClientResponseError = {code: string};
@@ -426,84 +422,11 @@ export class RequestSender {
     }
   }
 
-  _rawRequest(
-    method: string,
-    path: string,
-    params?: RequestData,
-    options?: RequestOptions
-  ): Promise<any> {
-    const requestPromise = new Promise<any>((resolve, reject) => {
-      let opts: RequestOpts;
-      try {
-        const requestMethod = method.toUpperCase();
-        if (
-          requestMethod !== 'POST' &&
-          params &&
-          Object.keys(params).length !== 0
-        ) {
-          throw new Error(
-            'rawRequest only supports params on POST requests. Please pass null and add your parameters to path.'
-          );
-        }
-        const args: RequestArgs = [].slice.call([params, options]);
-
-        // Pull request data and options (headers, auth) from args.
-        const dataFromArgs = getDataFromArgs(args);
-        const data = Object.assign({}, dataFromArgs);
-        const calculatedOptions = getOptionsFromArgs(args);
-
-        const headers = calculatedOptions.headers;
-
-        opts = {
-          requestMethod,
-          requestPath: path,
-          bodyData: data,
-          queryData: {},
-          auth: calculatedOptions.auth,
-          headers,
-          host: null,
-          streaming: false,
-          settings: {},
-          usage: ['raw_request'],
-        };
-      } catch (err) {
-        reject(err);
-        return;
-      }
-
-      function requestCallback(
-        err: any,
-        response: HttpClientResponseInterface
-      ): void {
-        if (err) {
-          reject(err);
-        } else {
-          resolve(response);
-        }
-      }
-
-      const {headers, settings} = opts;
-
-      this._request(
-        opts.requestMethod,
-        opts.host,
-        path,
-        opts.bodyData,
-        opts.auth,
-        {headers, settings, streaming: opts.streaming},
-        opts.usage,
-        requestCallback
-      );
-    });
-
-    return requestPromise;
-  }
-
   _request(
     method: string,
     host: string | null,
     path: string,
-    data: RequestData | null,
+    data: RequestData,
     auth: string | null,
     options: RequestOptions = {},
     usage: Array<string> = [],

diff --git a/src/Types.d.ts b/src/Types.d.ts
@@ -149,20 +149,8 @@ export type StripeObject = {
   _getPropsFromConfig: (config: Record<string, unknown>) => UserProvidedConfig;
   _clientId?: string;
   _platformFunctions: PlatformFunctions;
-  rawRequest: (
-    method: string,
-    path: string,
-    data: RequestData,
-    options: RequestOptions
-  ) => Promise<any>;
 };
 export type RequestSender = {
-  _rawRequest(
-    method: string,
-    path: string,
-    params?: RequestData,
-    options?: RequestOptions
-  ): Promise<any>;
   _request(
     method: string,
     host: string | null,
@@ -223,7 +211,7 @@ export type StripeResourceObject = {
 };
 export type RequestDataProcessor = (
   method: string,
-  data: RequestData | null,
+  data: RequestData,
   headers: RequestHeaders | undefined,
   prepareAndMakeRequest: (error: Error | null, data: string) => void
 ) => void;

diff --git a/src/stripe.core.ts b/src/stripe.core.ts
@@ -1,13 +1,7 @@
 import * as _Error from './Error.js';
 import {RequestSender} from './RequestSender.js';
 import {StripeResource} from './StripeResource.js';
-import {
-  AppInfo,
-  StripeObject,
-  RequestData,
-  RequestOptions,
-  UserProvidedConfig,
-} from './Types.js';
+import {AppInfo, StripeObject, UserProvidedConfig} from './Types.js';
 import {WebhookObject, createWebhooks} from './Webhooks.js';
 import * as apiVersion from './apiVersion.js';
 import {CryptoProvider} from './crypto/CryptoProvider.js';
@@ -214,15 +208,6 @@ export function createStripe(
     _requestSender: null!,
     _platformFunctions: null!,
 
-    rawRequest(
-      method: string,
-      path: string,
-      params?: RequestData,
-      options?: RequestOptions
-    ): Promise<any> {
-      return this._requestSender._rawRequest(method, path, params, options);
-    },
-
     /**
      * @private
      */

diff --git a/src/utils.ts b/src/utils.ts
@@ -16,7 +16,6 @@ const OPTIONS_KEYS = [
   'maxNetworkRetries',
   'timeout',
   'host',
-  'additionalHeaders',
 ];
 
 type Settings = {
@@ -29,7 +28,7 @@ type Options = {
   host: string | null;
   settings: Settings;
   streaming?: boolean;
-  headers: RequestHeaders;
+  headers: Record<string, unknown>;
 };
 
 export function isOptionsHash(o: unknown): boolean | unknown {
@@ -159,13 +158,13 @@ export function getOptionsFromArgs(args: RequestArgs): Options {
         opts.auth = params.apiKey as string;
       }
       if (params.idempotencyKey) {
-        opts.headers['Idempotency-Key'] = params.idempotencyKey as string;
+        opts.headers['Idempotency-Key'] = params.idempotencyKey;
       }
       if (params.stripeAccount) {
-        opts.headers['Stripe-Account'] = params.stripeAccount as string;
+        opts.headers['Stripe-Account'] = params.stripeAccount;
       }
       if (params.apiVersion) {
-        opts.headers['Stripe-Version'] = params.apiVersion as string;
+        opts.headers['Stripe-Version'] = params.apiVersion;
       }
       if (Number.isInteger(params.maxNetworkRetries)) {
         opts.settings.maxNetworkRetries = params.maxNetworkRetries as number;
@@ -176,11 +175,6 @@ export function getOptionsFromArgs(args: RequestArgs): Options {
       if (params.host) {
         opts.host = params.host as string;
       }
-      if (params.additionalHeaders) {
-        opts.headers = params.additionalHeaders as {
-          [headerName: string]: string;
-        };
-      }
     }
   }
   return opts;