Better CryptoProvider error #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
requested review from
anniel-stripe and
a team
and removed request for
anniel-stripe and
a team
anniel-stripe
approved these changes
Jun 26, 2023
Co-authored-by: anniel-stripe <[email protected]>
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
…ptoprovider-error Better CryptoProvider error
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
…ptoprovider-error Better CryptoProvider error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #1827.
SubtleCryptoProvider.computeHMACSignatureitself, but it felt wrong to me for.computeHMACSignatureto make assumptions about how it was called, so instead I introduced a specialized error class forconstructEventcan produce the message. Open to reversing this upon feedback..computeHMACSignatureto throw this error. That means we're asking hypothetical implementors of additional async-only CryptoProviders will have to explicitly override.computeHMACSignatureto throw this error instead of just only implementing.computeHMACSignatureAsync. This kind of is a bummer but I think it prevents misleading error messages in the hypothetical case where the implementer implements neither method. This almost certainly doesn't matter, but figured I'd mention.