Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "import * as http -> import http from 'http'" #1859

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Revert "import * as http -> import http from 'http'" #1859

merged 1 commit into from
Jul 28, 2023

Conversation

richardm-stripe
Copy link
Contributor

@richardm-stripe richardm-stripe commented Jul 28, 2023 •
edited
Loading

Reverts #1854

We should not use esModuleInterop because this is a breaking change

Accordingly, library authors should set both allowSyntheticDefaultImports and esModuleInterop to false. This allows consumers to opt into these semantics, but does not require them to do so. Consumers can always safely use alternative import syntaxes (including falling back to require() and import()), or can enable these flags and opt into this behavior themselves.

https://www.semver-ts.org/#module-interop

Thank you for catching this @anniel-stripe!

@richardm-stripe richardm-stripe marked this pull request as ready for review July 28, 2023 00:19
anniel-stripe
anniel-stripe approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@anniel-stripe anniel-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@richardm-stripe richardm-stripe merged commit 9c3c4ef into master Jul 28, 2023
@richardm-stripe richardm-stripe deleted the revert-1854-richardm-monkey-patchable-node-http branch July 28, 2023 00:22
@richardm-stripe richardm-stripe mentioned this pull request Jul 28, 2023
Merged
@MiulesiKulasekara MiulesiKulasekara mentioned this pull request Sep 24, 2024
Open
@nhungcontact nhungcontact mentioned this pull request Sep 24, 2024
Open
@IT21071034 IT21071034 mentioned this pull request Sep 25, 2024
Open
@Kavindya-Udunuwara Kavindya-Udunuwara mentioned this pull request Sep 25, 2024
Open
This was referenced Sep 26, 2024
Open
Open
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
@richardm-stripe
Merge pull request stripe#1859 from stripe/revert-1854-richardm-monke…
99aa83e 
…y-patchable-node-http

Revert "import * as http -> import http from 'http'"
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
@richardm-stripe
Merge pull request stripe#1859 from stripe/revert-1854-richardm-monke…
072b3a2 
…y-patchable-node-http

Revert "import * as http -> import http from 'http'"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anniel-stripe anniel-stripe anniel-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardm-stripe @anniel-stripe