Note on limit param in autoPagingToArray
#2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it more explicit that the `limit` value passed to `autoPagingToArray` is the limit for the total number of items that will be fetched from Stripe, and not a limit for the number of items retrieved per fetch during multiple rounds of fetching.
|
|
|
|
richardm-stripe
approved these changes
Apr 29, 2024
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
* Note on `limit` param in `autoPagingToArray` Makes it more explicit that the `limit` value passed to `autoPagingToArray` is the limit for the total number of items that will be fetched from Stripe, and not a limit for the number of items retrieved per fetch during multiple rounds of fetching. * Update README.md --------- Co-authored-by: Richard Marmorstein <[email protected]>
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
* Note on `limit` param in `autoPagingToArray` Makes it more explicit that the `limit` value passed to `autoPagingToArray` is the limit for the total number of items that will be fetched from Stripe, and not a limit for the number of items retrieved per fetch during multiple rounds of fetching. * Update README.md --------- Co-authored-by: Richard Marmorstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the
README.mdfile makes it more explicit that thelimitvalue passed toautoPagingToArrayis the limit for the total number of items that will be fetched from Stripe, and not a limit for the number of items retrieved per fetch during multiple rounds of fetching. The note about preventing runaway memory growth was suggestive of this behavior, but not entirely explicit.