Add support for the File Link resource #483
Conversation
|
Minor comment, but otherwise LGTM. |
| Disputes: require('./resources/Issuing/Disputes'), | ||
| Transactions: require('./resources/Issuing/Transactions'), |
There was a problem hiding this comment.
Hah, thanks for alphabetizing everything!
test/resources/FileLinks.spec.js
Outdated
| stripe.fileLinks.update('fl_123', {metadata: {key: 'value'}}); | ||
| expect(stripe.LAST_REQUEST).to.deep.equal({ | ||
| method: 'POST', | ||
| url: '/v1/file_links/fl_123', |
There was a problem hiding this comment.
Quite minor and I didn't notice on your PHP pull, but file link tokens have a test or live in them. This is unlike most resources, but is needed because you're not using a key that would hint which mode to load it in.
It might be slightly more accurate if we used an identifier like fl_live_123.
There was a problem hiding this comment.
Wait, that's only for the url attribute though. File links have a regular token, but it starts with link_, not with fl_.
There was a problem hiding this comment.
Oh oops. Yeah you're right — I got confused seeing the fl_.
There was a problem hiding this comment.
totally misread that from an earlier link I saw that had fl in it. Thanks for catching, I'll also fix in PHP
remi-stripe
force-pushed
the
remi-add-file-link
branch
from
4d95bf6 to
df44192
Compare
|
@brandur-stripe Fixed PTAL |
|
LGTM. |
|
Released as 6.6.0. |
r? @ob-stripe @brandur-stripe
cc @stripe/api-libraries