Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type for StripeError to extend Error #824

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

cjavilla-stripe
Copy link
Contributor

This matches the implemented type

r? @richardm-stripe

fixes #823

This matches the implemented type

fixes #823
@cjavilla-stripe
Copy link
Contributor Author

This file is not auto genned, so I just updated it directly. Not sure if we need to (or how to) cut a new release for this type of thing.

@cjavilla-stripe
Copy link
Contributor Author

cc @stripe/api-libraries

Copy link
Contributor

@rattrayalex-stripe rattrayalex-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't recall why we didn't do this in the first place (I think something about the type wasn't working) but our TS type test seems to pass so perhaps the reason doesn't apply anymore.

@rattrayalex-stripe rattrayalex-stripe merged commit f98bb08 into master Mar 2, 2020
@rattrayalex-stripe rattrayalex-stripe deleted the cjavilla/stripe-error-from-error branch March 2, 2020 18:55
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typescript] StripeError missing "extends Error"
4 participants