Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to update the api version #843

Merged
merged 5 commits into from
Mar 20, 2020

Conversation

rattrayalex-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries @remi-stripe

This automates the work done in #826 with a handy little regex script (and a new API_VERSION file, which is codegen'd).

It also:

  1. Removes Addresses.d.ts, which is obsolete – the definition for type Address lives in tyeps/shared.d.ts. I misadvised remi when I told him we need to keep it, I think.
  2. Updates the openapi spec, because it's hard not to.
  3. Add (and revert) a demo commit to show what would happen if you ran this for api version 2020-12-12: 059273c

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, but I think this may conflict with #842, be careful when merging.

@rattrayalex-stripe
Copy link
Contributor Author

Awesome thanks – I'll merge & release that one first.

@rattrayalex-stripe rattrayalex-stripe force-pushed the ralex/update-api-version-script branch from 8c57a7b to 1c0113f Compare March 20, 2020 19:59
@rattrayalex-stripe
Copy link
Contributor Author

I rebased and dropped the openapi update, since remi's PR should have been ahead of that if anything.

@rattrayalex-stripe rattrayalex-stripe merged commit 01c4800 into master Mar 20, 2020
@rattrayalex-stripe rattrayalex-stripe deleted the ralex/update-api-version-script branch March 20, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants