Redirect url should be urlencoded

[ambrt]

The user verify link is made in such way that it provides redirect path in the middle of whole link.

The problem is that when one would use redirect=/#/my-angular-path then the token is treated as hash valu and isn't read by api (to verify) and api throws error.
Redirect is added on line 407 and token on 431.

I would just remove:

   '&redirect=' +
      options.redirect;

from line 407 and put it behind
options.verifyHref += '&token=' + user.verificationToken;
on line 431

[superkhau]

Can you provide a sample repo for us to reproduce your issue?

[ambrt]

@superkhau Here's a sample of it https://github.com/ambrt/loopback-sandbox

[superkhau]

@davidcheung Reassigning to you as this is your FA.

[davidcheung]

@ambrt if we also url encode the redirectUrl would this already not be a problem? it is altering the url?

[ambrt]

Hi @davidcheung
Yes, I think that url encode here and url decode here would solve the problem.

[davidcheung]

actually i believe that would also mean if the url has parameters it will also be lost, we should fix this

[bajtos]

Closing in favour of #3185.

[bajtos]

Fixed.