Skip to content

Commit

Permalink
Don't restart dev services
Browse files Browse the repository at this point in the history
This slows down continuous testing, as the services have to be started
and stopped each time. It also doesn't actually work at the moment due
to quarkusio#17069
  • Loading branch information
stuartwdouglas committed Jul 28, 2021
1 parent 6ff45d3 commit 8779c16
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import io.quarkus.deployment.builditem.DevServicesNativeConfigResultBuildItem;
import io.quarkus.deployment.builditem.LaunchModeBuildItem;
import io.quarkus.deployment.builditem.RunTimeConfigurationDefaultBuildItem;
import io.quarkus.runtime.LaunchMode;
import io.quarkus.runtime.configuration.ConfigUtils;

/**
Expand Down Expand Up @@ -48,10 +47,7 @@ public void startApicurioRegistryDevService(
ApicurioRegistryDevServiceCfg configuration = getConfiguration(apicurioRegistryDevServices);

if (closeable != null) {
boolean restartRequired = launchMode.getLaunchMode() == LaunchMode.TEST;
if (!restartRequired) {
restartRequired = !configuration.equals(cfg);
}
boolean restartRequired = !configuration.equals(cfg);
if (!restartRequired) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@ public DevServicesKafkaBrokerBuildItem startKafkaDevService(
KafkaDevServiceCfg configuration = getConfiguration(kafkaClientBuildTimeConfig);

if (closeable != null) {
boolean shouldShutdownTheBroker = launchMode.getLaunchMode() == LaunchMode.TEST;
if (!shouldShutdownTheBroker) {
shouldShutdownTheBroker = !configuration.equals(cfg);
}
boolean shouldShutdownTheBroker = !configuration.equals(cfg);
if (!shouldShutdownTheBroker) {
return null;
}
Expand Down

0 comments on commit 8779c16

Please sign in to comment.