Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sub-monthly but non-daily datasets #35

Closed
HeatherSavoy-USDA opened this issue Feb 4, 2022 · 6 comments
Closed

sub-monthly but non-daily datasets #35

HeatherSavoy-USDA opened this issue Feb 4, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@HeatherSavoy-USDA
Copy link
Collaborator

Satellite missions data don't always fit into the daily or monthly temporal increment categories. The MODIS NDVI product that is currently the choice for the pilot is 8-day, so I'm including this issue in the pilot milestone.

Could the daily data implementation (#13) be general enough to recognize individual dates but not require every date within the requested date range?

I think this is also related to #31: instead of looping over every time increment in the requested data range (as is done in current monthly implementation), we can apply geospatial operations on a DataArray or Dataset that has filtered/concatenated time dimension matching the relevant date range.

@HeatherSavoy-USDA HeatherSavoy-USDA added the enhancement New feature or request label Feb 4, 2022
@stuckyb
Copy link
Owner

stuckyb commented Feb 4, 2022

Could the daily data implementation (#13) be general enough to recognize individual dates but not require every date within the requested date range?

Yes! The refactor and daily date implementation I am working on now will support this.

@HeatherSavoy-USDA
Copy link
Collaborator Author

This might change given discussion in #31, but what is the intended method for supporting sparse daily data if getData() is called on every date in a requested date range?

@stuckyb
Copy link
Owner

stuckyb commented Feb 24, 2022

Simplest method would be to let the datasets know what dates they support and return None or raise a targeted exception if they don't have data for a particular date. That way, other code doesn't have to care about trying to craft custom date requests for each dataset.

@stuckyb
Copy link
Owner

stuckyb commented Feb 24, 2022

Totally open to other ideas here, too! Other solutions I've considered would add complexity for little/no gain (at least, it seems that way to me).

@HeatherSavoy-USDA
Copy link
Collaborator Author

I believe the current plan is to determine the dates from the relevant file (or data store if remote) when it is opened (not repeatedly thanks to in-memory caching being implemented). This should be fairly straightforward with a netcdf file with a time dimension, which I think will be the case for most if not all datasets with this issue.

HeatherSavoy-USDA added a commit that referenced this issue Mar 7, 2022
For sparse daily data #35
And addresses #25
@HeatherSavoy-USDA
Copy link
Collaborator Author

This is resolved for MODIS_NDVI in 1e55354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants