fix(button): Fix prop types (#134)

* fix(button): Fix Button prop types * Change forwardRef types. * Remove explicit prop type in the component definition. (TSC can detect the type automatically from forwardRef now.) * fix(dropdown): Fix Dropdown prop types * fix(passwordInput): Fix typo * refactor(button): Remove ref property ref property comes automatically with forwardRef usage. * fix(dropdown): add combobox role Co-authored-by: Anılerkan <[email protected]>
studiobakers · Mar 11, 2022 · 7d98256 · 7d98256
1 parent 123025a
commit 7d98256
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/button/Button.tsx b/src/button/Button.tsx
@@ -17,14 +17,13 @@ export type ButtonProps = Omit<
   shouldPreventDefault?: boolean;
   shouldStopPropagation?: boolean;
   shouldFocus?: boolean;
-  ref?: React.RefObject<HTMLButtonElement>;
   shouldDisplaySpinner?: boolean;
   customClassName?: string;
 };
 
-const Button = React.forwardRef<HTMLButtonElement, Record<string, any>>(
+const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
   // eslint-disable-next-line prefer-arrow-callback
-  function ButtonComponent(props: ButtonProps, ref) {
+  function ButtonComponent(props, ref) {
     const {
       testid,
       type = "button",

diff --git a/src/dropdown/Dropdown.tsx b/src/dropdown/Dropdown.tsx
@@ -174,6 +174,7 @@ function Dropdown<OptionIdShape extends string>({
       onMouseUp={handleMouseUp}
       onClick={toggleDropdown}
       tabIndex={-1}
+      // @ts-ignore
       aria-haspopup={role}
       aria-expanded={isMenuOpen}
       shouldFocus={shouldFocusOnHeaderButton}>