Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stories): Rename story names #119

Closed
wants to merge 6 commits into from
Closed

refactor(stories): Rename story names #119

wants to merge 6 commits into from

Conversation

mfarukkoc
Copy link
Contributor

Description

Renamed story names:

  • Renamed Input States as Input
  • Renamed Checkbox States as Checkbox
  • Renamed Radio States as Radio Input
  • Renamed Dropdown States as Dropdown
  • Renamed Switch States as Switch
  • Renamed Toggle States as Toggle
  • Renamed Button States as Button
    • Renamed Upload Button States as Button
  • Renamed Typeahead States as Typeahead

Grouped stories:

  • Grouped FormField states in one story
  • Grouped TextArea states in one story
    • Add descriptive placeholders for each state.

Closes #116

mfarukkoc added 4 commits July 6, 2021 14:39
@mfarukkoc
refactor(stories): Rename story names
e586389 
- Input States -> Input
- Checkbox States -> Checkbox
- Radio States -> Radio Input
- Dropdown States -> Dropdown
- Switch States -> Switch
- Toggle States -> Toggle
- Button States -> Button
- Typeahead States -> Typeahead
@mfarukkoc
refactor(formField): Group FormField stories
259b2a9 
* Group FormField states in one story.
@mfarukkoc
refactor(textarea): Group Textarea stories
2c25208 
* Group FormField states in one story.
* Add descriptive placholders for each state.
@mfarukkoc
refactor(uploadButton): Rename story name
a05911b 
* Rename 'Upload Button States' to 'Upload Button'
@mfarukkoc mfarukkoc requested a review from mucahit July 6, 2021 12:03
@mfarukkoc mfarukkoc self-assigned this Jul 6, 2021
@mfarukkoc mfarukkoc linked an issue Jul 6, 2021 that may be closed by this pull request
Storybook: Rename story names #116
Closed
@mfarukkoc mfarukkoc requested a review from edizcelik July 7, 2021 12:58
mucahit
mucahit suggested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@mucahit mucahit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Requesting few minor changes.

@mfarukkoc
refactor(stories): Move each story under Form to their own story
cdc2582 
* Seperate stories under Form section to their own stories.
* Reorder story numbers.
@mfarukkoc mfarukkoc requested review from mucahit and edizcelik July 12, 2021 11:54
@mfarukkoc
refactor(inputStories): Rename the titles with FormField
c115c67 
* Rename "FormField with Input" to "Input with FormField".
@edizcelik edizcelik requested review from bilgeyucel and jamcry August 10, 2021 13:18
@edizcelik edizcelik added the Ready for new release PR is reviewed and ready to be merged label Aug 10, 2021
mucahit added a commit that referenced this pull request Aug 26, 2021
@mucahit
refactor(stories): Rename story names #119
6f42f3a
@mucahit
Copy link
Contributor

mucahit commented Aug 26, 2021

This is merged with this commit 6f42f3a

@mucahit mucahit closed this Aug 26, 2021
@mucahit mucahit deleted the feat/rename-story-names branch August 26, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mucahit mucahit mucahit approved these changes

@edizcelik edizcelik edizcelik approved these changes

@yasincaliskan yasincaliskan yasincaliskan approved these changes

@bilgeyucel bilgeyucel Awaiting requested review from bilgeyucel

@jamcry jamcry Awaiting requested review from jamcry

Assignees

@mfarukkoc mfarukkoc

Labels
Ready for new release PR is reviewed and ready to be merged ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook: Rename story names
4 participants
@mfarukkoc @mucahit @edizcelik @yasincaliskan