feat(toast): Add limit prop to ToastProvider #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add optional limit prop to limit the maximum number of toasts.
edizcelik
suggested changes
Jul 9, 2021
* Move toast limit to context state from toast display action props.
edizcelik
suggested changes
Jul 12, 2021
* Add effect that listens the changes on limit and autoCloseToasts prop * Add story section under Toast for showing dynamic changes.
* Change SET_LIMIT action pruning target to 'firstly added toasts' from 'lastly added toasts'. * Update shift method usage with slice method.
mucahit
approved these changes
Jul 22, 2021
jamcry
reviewed
Jul 30, 2021
* Refactor logic in the "SET_DISPLAY" action with the approach in the "DISPLAY" action. * Change line-breaks between code lines to increase readability. * Remove destructuring operation in "SET_AUTO_CLOSE" action, use the action prop directly.
yasincaliskan
approved these changes
Jul 30, 2021
edizcelik
reviewed
Aug 10, 2021
* Update the logic of checking if the limit is defined.
mucahit
added
Ready for new release
edizcelik
suggested changes
Aug 26, 2021
edizcelik
removed
the
Ready for new release
edizcelik
requested review from
edizcelik,
mucahit,
yasincaliskan and
Anlerkan
mucahit
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #112