feat(typeahead): Change input style #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change style to stretch input dynamically to fit after tags. * Increase the width of the Typeahead story page to show the dynamic stretching better.
* Add extra prop to render an extra component after the list items.
* Refactor Typeahead component with new List props to dynamically fit input after tags when tags overflow to a new line. * Rename '.typeahead-select__tag-list' to '.typeahead-select__header-list'.
mfarukkoc
added
ready for review
W.I.P
This reverts commit 8a6ea03.
* Create TypeaheadList for special use case of the component, an extra input element should be rendered after the list items. * Update TypeaheadSelect with newly created component.
mucahit
suggested changes
Jul 22, 2021
* Rename "TypeaheadList" to "TypeaheadSelectHeader"
jamcry
reviewed
Jul 30, 2021
edizcelik
reviewed
Aug 26, 2021
edizcelik
approved these changes
Sep 16, 2021
mucahit
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extraprop to the List to render an extra component after list items, input should be in the same flex-box with the tags for the dynamic adjustment when tags overflow to a new line..typeahead-select__tag-listto.typeahead-select__header-listbecause list is no longer just rendering tags but also renders input.Closes #45