Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update husky #140

Merged
merged 3 commits into from
Aug 26, 2021
Merged

build: Update husky #140

merged 3 commits into from
Aug 26, 2021

Conversation

mfarukkoc
Copy link
Contributor

Description

  • Updated husky from v4 to v7 to fix the pre-commit hook problem.

Pre-commit hook working on Node v14.17.3 and NPM 6.14.10 on Windows 10.

Fixes #135

@mfarukkoc mfarukkoc self-assigned this Jul 26, 2021
@mfarukkoc mfarukkoc requested review from jamcry and bilgeyucel July 26, 2021 13:48
yasincaliskan
yasincaliskan approved these changes Aug 6, 2021
View reviewed changes
@mucahit mucahit added Ready for new release PR is reviewed and ready to be merged and removed ready for review labels Aug 19, 2021
edizcelik
edizcelik reviewed Aug 26, 2021
View reviewed changes
Copy link
Contributor

@edizcelik edizcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a prepare script ?

"prepare": "husky install",

@mucahit mucahit merged commit 02214b2 into next-release Aug 26, 2021
@mucahit mucahit deleted the feat/update-husky branch August 26, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edizcelik edizcelik edizcelik left review comments

@mucahit mucahit mucahit approved these changes

@jamcry jamcry jamcry approved these changes

@Anlerkan Anlerkan Anlerkan approved these changes

@yasincaliskan yasincaliskan yasincaliskan approved these changes

@bilgeyucel bilgeyucel Awaiting requested review from bilgeyucel

Assignees

@mfarukkoc mfarukkoc

Labels
Ready for new release PR is reviewed and ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mfarukkoc @mucahit @edizcelik @jamcry @Anlerkan @yasincaliskan